Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Improve handling of registry challenge requests #1672

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Improve handling of registry challenge requests #1672

merged 2 commits into from
Jan 17, 2019

Conversation

2opremio
Copy link
Contributor

  1. Close the response body, which wasn't getting closed and which is partly or fully causing Goroutine leak in fluxd? #1602
  2. Include a timeout in the request

Alfonso Acosta added 2 commits January 17, 2019 18:19
squaremo
squaremo approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Fons

@2opremio 2opremio mentioned this pull request Jan 17, 2019
Closed
@2opremio 2opremio merged commit 2441121 into fluxcd:master Jan 17, 2019
@2opremio 2opremio deleted the 1602-fix-registry-socket-leak branch January 17, 2019 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2opremio @squaremo