Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix flaky cached discovery test #1849

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

2opremio
Copy link
Contributor

The synchronization handle needs to be called last, to make sure the invalidation
handle is called before invoking lookupNamespaced()

@2opremio 2opremio requested a review from squaremo March 20, 2019 23:50
@2opremio 2opremio changed the title Fix flakey cache discovery test Fix flaky cache discovery test Mar 21, 2019
@2opremio 2opremio force-pushed the fix-flakey-discovery-test branch from b32badd to 60cb318 Compare March 21, 2019 00:40
@2opremio 2opremio changed the title Fix flaky cache discovery test Fix flaky cached discovery test Mar 21, 2019
The synchronization handle needs to be called last, to make sure the invalidation
handle is called before invoking `lookupNamespaced()`
@2opremio 2opremio force-pushed the fix-flakey-discovery-test branch from 60cb318 to 20e8abd Compare March 21, 2019 00:49
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Then we're not at the mercy of the go scheduler.

@2opremio 2opremio merged commit 88402e3 into fluxcd:master Mar 21, 2019
@2opremio 2opremio deleted the fix-flakey-discovery-test branch March 21, 2019 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants