This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Invalidate discovery cache periodically #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cluster resource definitions may not be stable throughout the life of the cluster. We were already invalidating the cache every time a CRD object was altered and replaying the CRD changes every 5 minutes. However, that's not enough because CRD-unrelated changes seem to happen when the cluster bootstraps.
2opremio
force-pushed
the
1855-reset-discovery-cache-periodically
branch
from
c2f21ef to
33abf1d
Compare
squaremo
reviewed
Mar 26, 2019
squaremo
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster resource definitions may not be stable throughout the life of the cluster.
We were already invalidating the cache every time a CRD object was altered and replaying the CRD changes every 5 minutes.
However, that's not enough because CRD-unrelated changes seem to happen when the cluster bootstraps.
Fixes #1855