Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support lists of all resource kinds #1883

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Apr 1, 2019

Flux supported heterogeneous resource Lists, however it didn't support
resource-kind specific lists such as RoleList unlike kubectl.

This changes parsing of lists to align flux's behavior with kubectl's.

Fixes #1860

Flux supported heterogeneous resource `List`s, however it didn't support
resource-kind specific lists such as `RoleList` unlike `kubectl`.

This changes parsing of lists to align `flux`'s behavior with `kubectl`'s.
@2opremio 2opremio requested a review from hiddeco April 1, 2019 09:38
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it should do. Thanks Fons ☀️

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@2opremio 2opremio merged commit 1916fe8 into fluxcd:master Apr 1, 2019
@2opremio 2opremio deleted the 1860-support-all-lists branch April 1, 2019 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants