This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add a timeout to all registry requests #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed until distribution/distribution#2905 is merged.
2opremio
commented
Apr 24, 2019
| cacheClient: cacheClient, | ||
| func newRepoCacheManager(now time.Time, | ||
| repoID image.Name, clientFactory registry.ClientFactory, creds registry.Credentials, repoClientTimeout time.Duration, | ||
| burst int, trace bool, logger log.Logger, cacheClient Client) (*repoCacheManager, error) { |
There was a problem hiding this comment.
I don't think the amount of parameters (which comes from the previous refactoring I made) is reasonable at all.
I tried a few alternatives but they were worse. Any suggestions?
There was a problem hiding this comment.
Some people (including me occasionally) wrap optional values in a config struct, which is passed by value.
There was a problem hiding this comment.
Uhm, only one (or maybe two) are really optional.
hiddeco
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) fixes #1940 and #1808
Registry request could get stuck indefinitely due to a combination of:
The repository client we use:
This has been addressed by Honor contexts passed to registry client methods distribution/distribution#2905 , prompting me to replace https://github.com/docker/distribution by https://github.com/2opremio/distribution until the PR is merged.
We didn't set any context deadline we just set the context
Background()