This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Log warning re not applying resource by namespace #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
May 9, 2019
squaremo
force-pushed
the
log-ignored-by-sync
branch
from
cd1816e to
a9c6fc1
Compare
|
@hiddeco I changed it so it logs all the excluded resources in one line, if there are any. Can you have a quick log and make sure you're still happy with it? |
hiddeco
approved these changes
May 13, 2019
squaremo
force-pushed
the
log-ignored-by-sync
branch
from
a9c6fc1 to
f42ab75
Compare
We log when a resource in a manifest is dropped from sync because it's marked as ignored; would also help troubleshooting if we log when a resource is dropped because it's not in the allowed namespaces.
Logging all excluded resources may be quite noisy. Instead, collect the IDs of excluded resources and log once (or no times, if there aren't any).
squaremo
force-pushed
the
log-ignored-by-sync
branch
from
f42ab75 to
c3f0fe2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We log when a resource in a manifest is dropped from sync because it's
marked as ignored; would also help troubleshooting if we log when a
resource is dropped because it's not in the allowed namespaces.
Fixes #2012.