This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix e2e tests #2050
Merged
Fix e2e tests #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
May 16, 2019
2opremio
force-pushed
the
fix-e2e-tests
branch
2 times, most recently
from
caff9cc to
439e6d8
Compare
In order for the initialization to retry if there is a netwroking glitch
Using master broke connectivity with the external world (at least when used CircleCI)
|
@hiddeco PTAL |
hiddeco
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there are connectivity problems when starting the Kubernetes cluster in Circle. Hopefully they are transient, and this update (which includes fluxcd/gitsrv#7 ) will fix the end to end tests.External connectivity broke in kind/master. The solution was to pin it to version 0.2.1
Also, on the way I bumped
gitsrvso that it retries its initialization indefinitely if there is a connectivity problem.