This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make TestCachedDiscovery more robust #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were relying on an Add event happening, but sometimes there is an Add followed by an update. As a bonus, we don't need to split the constructor in two
2opremio
force-pushed
the
flaky-disco-test
branch
from
8ea2ce4 to
df07d9c
Compare
hiddeco
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on an Add event happening, but sometimes there is an Add followed by an Update.
As a bonus, we don't need to split the constructor in two