Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Enable connection to a Remote Cluster for easy development #2140

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Enable connection to a Remote Cluster for easy development #2140

merged 2 commits into from
Jun 10, 2019

Conversation

bzon
Copy link
Contributor

@bzon bzon commented Jun 9, 2019

Propose Change

Enable running fluxd binary locally.

go run cmd/fluxd/main.go \
    --memcached-hostname localhost  \
    --memcached-port 11211 \
    --memcached-service "" \
    --git-url [email protected]:bzon/flux-get-started \
    --k8s-in-cluster=false

This is a continuation of the unmaintained PR #1156 started by @andersjanmyr.

I had to add an implementation of ssh.KeyRing interface because without it, fluxctl -u http://localhost:3030/api/flux [command] makes fluxd panics with the below error:

2019/06/09 17:27:51 http: panic serving [::1]:58686: runtime error: invalid memory address or nil pointer dereference
goroutine 767 [running]:
net/http.(*conn).serve.func1(0xc0006365a0)
	/usr/local/Cellar/go/1.11.5/libexec/src/net/http/server.go:1746 +0xd0
panic(0x2159f60, 0x31a9640)
	/usr/local/Cellar/go/1.11.5/libexec/src/runtime/panic.go:513 +0x1b9
github.com/weaveworks/flux/cluster/kubernetes.(*Cluster).PublicSSHKey(0xc0005180f0, 0x12f6500, 0xc0003f0868, 0x2076740, 0xc000611b84, 0x16, 0x0)
	/Users/jb/Golang/src/github.com/weaveworks/flux/cluster/kubernetes/kubernetes.go:276 +0x3a
github.com/weaveworks/flux/daemon.(*Daemon).GitRepoConfig(0xc00033a120, 0x255a2c0, 0xc0004db770, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/jb/Golang/src/github.com/weaveworks/flux/daemon/daemon.go:610 +0x83
github.com/weaveworks/flux/http/daemon.HTTPServer.GitRepoConfig(0x256c940, 0xc00033a120, 0x254bec0, 0xc0007bfdc0, 0xc000ec8600)
	/Users/jb/Golang/src/github.com/weaveworks/flux/http/daemon/server.go:187 +0x181
github.com/weaveworks/flux/http/daemon.HTTPServer.GitRepoConfig-fm(0x254bec0, 0xc0007bfdc0, 0xc000ec8600)
	/Users/jb/Golang/src/github.com/weaveworks/flux/http/daemon/server.go:59 +0x57

@bzon bzon marked this pull request as ready for review June 9, 2019 18:11
@bzon bzon changed the title [Work-In-Progress] Enable connection to a Remote Cluster for easy development Enable connection to a Remote Cluster for easy development Jun 9, 2019
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me -- nicely done.

@squaremo squaremo merged commit 14a9b0f into fluxcd:master Jun 10, 2019
@bzon bzon deleted the enable-local-development branch June 10, 2019 13:44
@hiddeco hiddeco added this to the v1.13.0 milestone Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants