This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Only require image TS when it is used for sorting #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squaremo
approved these changes
Jul 1, 2019
As the semver filter does not make use of the image creation timestamp for filtering and sorting images, but instead has its own logic based on the semver spec, the block for automated image updates when a timestamp was missing for an image with a semver filter policy did more harm than good. This commit introduces a `RequiresTimestamp` method on the `Pattern` interface to indicate if the filter needs the timestamps on images to be present to give a reliable filtered and sorted output. Which is implemented in `calculateChanges`, so we only bail on missing timestamps when they are actually required.
hiddeco
force-pushed
the
enhancement/zero-created-ts-semver
branch
from
f5cd554 to
b4558a5
Compare
squaremo
pushed a commit
that referenced
this pull request
Jul 10, 2019
Only require image TS when it is used for sorting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the semver filter does not make use of the image creation timestamp
for filtering and sorting images, but instead has its own logic based
on the semver spec, the block for automated image updates when a
timestamp was missing for an image with a semver filter policy did more
harm than good.
This commit introduces a
RequiresTimestampmethod on thePatterninterface to indicate if the filter needs the timestamps on images to
be present to give a reliable filtered and sorted output. Which is
implemented in
calculateChanges, so we only bail on missingtimestamps when they are actually required.
Addresses #2172, but is by no means a fix.