This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow Google Cloud SDK env entries for git #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Yeap, looks okay. 💯
I think the proposed flag for allowed environment variables in the issue is a great idea to serve a wide range of users, edge cases and people with unorthodox desires, without having to update this []string every time. But this probably requires some brain exercise in how we would inject those values, given the current state of the git package.
Usng git with Google Cloud requires a git credential helper; this is less painful if the env entries it expects can be passed through to git (which will pass them on to the helper. See #2119.
squaremo
force-pushed
the
issue/2119-allow-google-cloudsdk-env
branch
from
df3ab8d to
a4e692a
Compare
squaremo
added a commit
that referenced
this pull request
Jul 10, 2019
…dsdk-env Allow Google Cloud SDK env entries for git
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usng git with Google Cloud requires a git credential helper; this is
less painful if the env entries it expects can be passed through to
git (which will pass them on to the helper.
Addresses #2119.