Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to collectors #2606

Closed
jpellizzari opened this issue Mar 25, 2023 · 4 comments
Closed

Add test coverage to collectors #2606

jpellizzari opened this issue Mar 25, 2023 · 4 comments

Comments

@jpellizzari
Copy link
Contributor

We need automated test coverage on:

  • pkg/collector
  • pkg/rolecollector
  • pkg/objectscollector
@jpellizzari
Copy link
Contributor Author

cc @squaremo If you can post your multi-cluster envtest stuff that would be awesome!

@squaremo
Copy link
Contributor

squaremo commented May 3, 2023

This is what I've done for a similar testing requirement: https://github.com/weaveworks-experiments/fleeet/blob/main/module/controllers/remote_test.go#L137
It's not horrendously expensive, but it does run >1 etcd; I think in theory it's possible to multiplex onto a single etcd, but I balked at trying that.

@enekofb
Copy link
Contributor

enekofb commented Jun 7, 2023

See for example an integration test for collector in another PR

It would be useful to consider it in this ticket

@jpellizzari
Copy link
Contributor Author

We have a larger suite built out now that hit major parts of the collector. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants