"Received invalid state update!" error could be more helpful

[bboreham]

Start weave on two hosts, then connect them (breaking the rules on initpeercount):

host1$ sudo weave launch-router
host1$ sudo weave run -ti ubuntu
host2$ sudo weave launch-router
host2$ sudo weave run -ti ubuntu
host1$ sudo weave connect host2

weave logs:

INFO: 2015/07/17 11:01:41.893191 ->[192.168.48.11:6783|3e:b0:2f:de:5e:da(host1)]: connection added (new peer)
ERRO: 2015/07/17 11:01:41.894079 ->[192.168.48.11:6783|3e:b0:2f:de:5e:da(host1)]: connection shutting down due to error: Received invalid state update!

Related: #760 (comment) - the message there is different but similarly unhelpful

[inercia]

In addition, it seems there is a memory leak that in the router when all these connections fail with the "Received invalid state update!" error. The router took more than 1,5Gb in my Vagrant before it was killed...

[rade]

it seems there is a memory leak

@inercia Do you see that with the exact same steps that @bboreham posted?

[inercia]

@rade Basically the same steps, while testing Discovery in my Vagrants. If I launch the router with no -initpeercount, Discovery sends /connects to the router, so I think it is basically the same (maybe the only different would be that connects would be in random order)

[rade]

Hmm. Running @bboreham's example I too see a steady memory growth. So this is rather more serious then. Please file a separate bug.