Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rspack does not seem to warn about missing exports, like webpack does #5967

Closed
MagicDuck opened this issue Mar 19, 2024 · 5 comments · Fixed by #6660
Closed

[Bug]: rspack does not seem to warn about missing exports, like webpack does #5967

MagicDuck opened this issue Mar 19, 2024 · 5 comments · Fixed by #6660
Assignees
Labels
bug Something isn't working

Comments

@MagicDuck
Copy link

MagicDuck commented Mar 19, 2024

System Info

"@rspack/cli": "^0.5.7",
"@rspack/core": "^0.5.7",
"@rspack/plugin-react-refresh": "^0.5.7",

Details

First, thank you for this awesome tool. It's already speeding up our build immensely!
Just running into a minor issue.
When an export is missing/invalid, webpack will helpfully warn about it. rspack seems to be missing this functionality atm.
Would be a great helper to have that warning show up.

Example warn from webpack:
image

Reproduce link

No response

Reproduce Steps

simply have an import like:

a.js
-------
import foo, {something} from 'bar'

b.js
------
export const something = 42;
// note no default export
@MagicDuck MagicDuck added bug Something isn't working pending triage The issue/PR is currently untouched. labels Mar 19, 2024
@ahabhgk ahabhgk self-assigned this Mar 21, 2024
@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Mar 22, 2024
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Mar 22, 2024

Should warn and provide better diagnostic than webpack. Error frame should print with span.

Copy link

stale bot commented May 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label May 21, 2024
@ahabhgk
Copy link
Contributor

ahabhgk commented May 21, 2024

bump, I will take a look in next week

@stale stale bot removed the stale label May 21, 2024
@ahabhgk ahabhgk linked a pull request May 30, 2024 that will close this issue
2 tasks
@ahabhgk
Copy link
Contributor

ahabhgk commented May 30, 2024

Supported by #6660, will be released in v0.7.1

@ahabhgk ahabhgk closed this as completed May 30, 2024
@MagicDuck
Copy link
Author

nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants