-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Enhance navbar
to integrate more configuration
#1713
Comments
Can we make |
If I correctly understand what |
What's the difference between |
Ok I understand so there is a bug actually because on mobile the navbar is not sticky at the top. I will fix this in a PR so |
What problem does this feature solve?
Currently, we have no way to make the navbar sticky on mobile, which I think could be improved. I propose adding a navbar object in the theme config to allow configuration of various navbar elements, such as its position (sticky or not) on mobile and desktop.
Additionally, we could integrate the hideNavbar functionality into a hide field within the navbar object. If we decide to move hideNavbar, we could deprecate it first before fully migrating to avoid breaking compatibility.
I'm not sure what you think about this approach and whether it would be suitable. What are your thoughts?
I can propose myself to do this change.
What does the proposed API look like?
The text was updated successfully, but these errors were encountered: