-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error handling for missing attrs in aria-utils.js #74
add error handling for missing attrs in aria-utils.js #74
Comments
Agreed! I was also curious why we weren't using "name" across the board (as opposed to |
For completeness, "name" is common in Windows Accessibility APIs, but not Mac/iOS. There are concepts of accessible labels on all platforms, but IIRC only Window makes the distinction between the terms assuming Since there were already a number of unrelated-to-accessibility uses of "name" in the Web Platform, the ARIA WG went with "computed label" follows that pattern... I recall the reason AccName uses "name" is mainly editorial—as in, the primary editor at the time came from the Windows side and liked "name" better. There were a number of Windows-style artifacts in the original ARIA spec. Many still exist in some form. |
@janewman interested in this issue. Will work with @benbeaudry or @chrishtr to get into the Interop GH team. |
A colleague mentioned they'd put
data-expectedname
in the markup instead ofdata-expectedlabel
, butverifyLabelsbySelectors()
didn't give a clear error that the attr was actually missing. Presumably it just calledel.getAttribute('data-expectedlabel')
and got back an empty string for the comparison.We can probably fix that and similar issues by throwing more errors or warnings in several places.
The text was updated successfully, but these errors were encountered: