Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate/add showPicker() tests #81

Closed
foolip opened this issue May 17, 2022 · 7 comments
Closed

Reinstate/add showPicker() tests #81

foolip opened this issue May 17, 2022 · 7 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@foolip
Copy link
Member

foolip commented May 17, 2022

For Forms, we originally had show-picker.html and show-picker-cross-origin-iframe.html labeled for Interop 2022.

In discussion with @ziransun we found that show-picker.html has since been renamed (web-platform-tests/wpt#33465) and then accidentally dropped from the test list in web-platform-tests/wpt-metadata@6eea9fe.

Reinstating the renamed test is probably uncontroversial, but @ziransun has also added a new test so I'd like to suggest adding both. Here they are:

https://wpt.fyi/results/html/semantics/forms/the-input-element?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=show-picker

show-picker-user-gesture.html is the original test renamed, while show-picker-disabled-readonly.html is the new test, with failures in Chrome and Safari.

@foolip foolip added the test-change-proposal Proposal to add or remove tests for an interop area label May 17, 2022
@foolip foolip changed the title Reinstate/add filePicker() tests Reinstate/add showPicker() tests May 26, 2022
@foolip
Copy link
Member Author

foolip commented May 26, 2022

@josepharhar can you check out the show-picker-disabled-readonly.html tests and see if including that in Interop 2022 would be reasonable?

@foolip
Copy link
Member Author

foolip commented Jun 8, 2022

@jgraham @gsnedders could you find the right people to weigh in on this for Gecko and WebKit?

@josepharhar
Copy link

If we already have/had showPicker tests in interop2022, I don't see anything wrong with including all three of the showPicker tests in the link.
It looks like the new disabled-readonly test was specced here, so I don't think there would be any contention over including it: whatwg/html#7769

@foolip
Copy link
Member Author

foolip commented Jun 8, 2022

Thanks @josepharhar!

@gsnedders
Copy link
Member

accidentally dropped from the test list in web-platform-tests/wpt-metadata@6eea9fe

On the whole, I'm in favour of re-adding it given it was accidentally removed. It was there at the start of Interop 2022, and it isn't now.

@jgraham
Copy link
Contributor

jgraham commented Jun 22, 2022

This seems fine.

@foolip
Copy link
Member Author

foolip commented Jun 23, 2022

The two additional tests were labeled in web-platform-tests/wpt-metadata#2813.

@foolip foolip closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

4 participants