From 70e34271f5e354ff86b65127d37930228d2f0711 Mon Sep 17 00:00:00 2001 From: Alison Maher Date: Mon, 17 Feb 2020 20:26:39 -0800 Subject: [PATCH] Don't adjust SVG text in forced colors mode As per the following spec resolution, SVG text no longer should be adjusted in forced colors mode by default. https://github.com/w3c/csswg-drafts/issues/3855 Bug: 970285 Change-Id: I11a785f64ca6f7e7840b17d6b59d4ce9b9f8b4e1 --- ...ef.html => forced-colors-mode-18-ref.html} | 8 +++---- ...tative.html => forced-colors-mode-18.html} | 16 ++++++------- .../forced-colors-mode-26-ref.html | 15 ++++++++++++ forced-colors-mode/forced-colors-mode-26.html | 20 ++++++++++++++++ .../forced-colors-mode-26.tentative-ref.html | 16 ------------- .../forced-colors-mode-26.tentative.html | 23 ------------------- 6 files changed, 46 insertions(+), 52 deletions(-) rename forced-colors-mode/{forced-colors-mode-18.tentative-ref.html => forced-colors-mode-18-ref.html} (74%) rename forced-colors-mode/{forced-colors-mode-18.tentative.html => forced-colors-mode-18.html} (52%) create mode 100644 forced-colors-mode/forced-colors-mode-26-ref.html create mode 100644 forced-colors-mode/forced-colors-mode-26.html delete mode 100644 forced-colors-mode/forced-colors-mode-26.tentative-ref.html delete mode 100644 forced-colors-mode/forced-colors-mode-26.tentative.html diff --git a/forced-colors-mode/forced-colors-mode-18.tentative-ref.html b/forced-colors-mode/forced-colors-mode-18-ref.html similarity index 74% rename from forced-colors-mode/forced-colors-mode-18.tentative-ref.html rename to forced-colors-mode/forced-colors-mode-18-ref.html index 34eba583caa924d..7d2f6b3f7071c97 100644 --- a/forced-colors-mode/forced-colors-mode-18.tentative-ref.html +++ b/forced-colors-mode/forced-colors-mode-18-ref.html @@ -1,7 +1,7 @@ -Forced colors mode - fill and stroke reference. - Only text and foreignObject svg elements should have fill and stroke +<title>Forced colors mode - svg. + Only foreignObject svg elements should have styles overridden in forced colors mode. - - This text should have a WindowText fill and transparent stroke color in + + This text should have a red fill and blue stroke color in forced colors mode. diff --git a/forced-colors-mode/forced-colors-mode-18.tentative.html b/forced-colors-mode/forced-colors-mode-18.html similarity index 52% rename from forced-colors-mode/forced-colors-mode-18.tentative.html rename to forced-colors-mode/forced-colors-mode-18.html index 307420af9fc7719..a30b93c29c92620 100644 --- a/forced-colors-mode/forced-colors-mode-18.tentative.html +++ b/forced-colors-mode/forced-colors-mode-18.html @@ -1,22 +1,20 @@ -Forced colors mode - fill and stroke. - Only text and foreignObject svg elements should have fill and stroke +<title>Forced colors mode - svg. + Only foreignObject svg elements should have styles overridden in forced colors mode. - + - - + - This text should have a WindowText fill and transparent stroke color in + This text should have a red fill and blue stroke color in forced colors mode. - -
+ +
This text should be WindowText color in forced colors mode.
diff --git a/forced-colors-mode/forced-colors-mode-26-ref.html b/forced-colors-mode/forced-colors-mode-26-ref.html new file mode 100644 index 000000000000000..39caee40b52aca0 --- /dev/null +++ b/forced-colors-mode/forced-colors-mode-26-ref.html @@ -0,0 +1,15 @@ + + +Forced colors mode - fill/stroke. + + + + The triangle below should be currentColor when forced colors mode. + + + + diff --git a/forced-colors-mode/forced-colors-mode-26.html b/forced-colors-mode/forced-colors-mode-26.html new file mode 100644 index 000000000000000..a9aa59013217ecd --- /dev/null +++ b/forced-colors-mode/forced-colors-mode-26.html @@ -0,0 +1,20 @@ + + +Forced colors mode - fill/stroke. + + + + + +
+ The triangle below should be currentColor when forced colors mode. + + + +
+ diff --git a/forced-colors-mode/forced-colors-mode-26.tentative-ref.html b/forced-colors-mode/forced-colors-mode-26.tentative-ref.html deleted file mode 100644 index f551a434290652d..000000000000000 --- a/forced-colors-mode/forced-colors-mode-26.tentative-ref.html +++ /dev/null @@ -1,16 +0,0 @@ - - -Forced colors mode - fill/stroke inheritance. - Tests that fill and stroke colors are properly inherited from parent elements. - - - - The triangle below should be red when forced colors mode is enabled and disabled. - - - - diff --git a/forced-colors-mode/forced-colors-mode-26.tentative.html b/forced-colors-mode/forced-colors-mode-26.tentative.html deleted file mode 100644 index ac21cae23805ffe..000000000000000 --- a/forced-colors-mode/forced-colors-mode-26.tentative.html +++ /dev/null @@ -1,23 +0,0 @@ - - -Forced colors mode - fill/stroke inheritance. - Tests that fill and stroke colors are properly inherited from parent elements. - - - - - -
- The triangle below should be red when forced colors mode is enabled and disabled. - - - - -
-