Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to test which cursor is used #7750

Open
gsnedders opened this issue Oct 13, 2017 · 5 comments
Open

Unable to test which cursor is used #7750

gsnedders opened this issue Oct 13, 2017 · 5 comments

Comments

@gsnedders
Copy link
Member

At the moment, we have no way to test the CSS cursor property. We probably need some ability to take a screenshot of the cursor at a specific place.

cc/ @frivoal

@frivoal
Copy link
Contributor

frivoal commented Oct 14, 2017

Right. Currently all cursor tests are manual, and that's lousy.

@RByers
Copy link
Contributor

RByers commented Nov 3, 2017

FWIW, years ago I added a mechanism in chromium to read back the cursor state (including custom bitmaps). I think that's probably more practical than doing screenshot diffing - at least for the OS defined cursors.

@gsnedders
Copy link
Member Author

@RByers There are tests for things like colour space and size of image cursors, which means you need more than just state.

@gsnedders gsnedders removed the css-ui-4 label Nov 6, 2017
@foolip
Copy link
Member

foolip commented Nov 9, 2017

It seems like in order to automate this, you'd need to take a screenshot of the whole desktop environment. A handful of manual tests for this might be an OK tradeoff :)

@frivoal
Copy link
Contributor

frivoal commented Nov 9, 2017

Indeed. Image cursors would be quite a pain to test, but even worse are the various predefined cursors, that don't even have a set shape, and need human judgement to decide if the cursor is indeed a cursor that "Indicates something is to be copied. Often rendered as an arrow with a small plus sign next to it."

If someone has a bright idea, that'd be great, but otherwise, we can certainly focus our energy better somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants