From 8e0ec4f0757248a277781a06be9ab207dc6cc142 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 21 Nov 2018 15:46:44 +1100 Subject: [PATCH 1/2] fix: make PMIs conform to spec --- .../payment-request-canmakepayment-method.https.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payment-method-basic-card/payment-request-canmakepayment-method.https.html b/payment-method-basic-card/payment-request-canmakepayment-method.https.html index a89c63b1bbc8aa..f1b0c28abb8867 100644 --- a/payment-method-basic-card/payment-request-canmakepayment-method.https.html +++ b/payment-method-basic-card/payment-request-canmakepayment-method.https.html @@ -33,7 +33,7 @@ function* pmiGenerator(howMany = 256) { for (i = 0; i < howMany; i++) { yield { - supportedMethods: `this-is-not-supported-${i}`, + supportedMethods: `this-is-not-supported`, data: { key: "value" }, }; } From ee77ceced2790d1ab350b2fefc63d9d97c9205b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 21 Nov 2018 18:58:49 +1100 Subject: [PATCH 2/2] Bug fixes --- .../empty-data-manual.https.html | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/payment-method-basic-card/empty-data-manual.https.html b/payment-method-basic-card/empty-data-manual.https.html index 2392553ebd3742..ba881ee2366c49 100644 --- a/payment-method-basic-card/empty-data-manual.https.html +++ b/payment-method-basic-card/empty-data-manual.https.html @@ -39,8 +39,8 @@ }; async function getCardResponse(data) { - const method = Object.assign({ data }, methodCard); - const response = await new PaymentRequest([method], defaultDetails).show(); + const payMethod = Object.assign({ data }, method); + const response = await new PaymentRequest([payMethod], details).show(); await response.complete("success"); return response.details; } @@ -54,7 +54,7 @@ promise_test(async () => { const card = await getCardResponse(data); for (const [member, expectedValue] of Object.entries(expectedCard)) { - const msg = `Expected card.${member} to equal ${expectedValue}.`; + const msg = `Expected "card.${member}" to equal "${expectedValue}".`; assert_equals(card[member], expectedValue, msg); } const { billingAddress } = card; @@ -120,6 +120,11 @@

Returns a card on any network, because zero length supportedNetworks. +
  • + +