From ed5033fad7cc572dc582a239b185717b1e3acd50 Mon Sep 17 00:00:00 2001 From: James Craig Date: Wed, 4 Oct 2023 18:46:39 -0700 Subject: [PATCH 01/15] incomplete commit to raise issues (these may be implementation bugs or may be spec probs) --- accname/name/comp_name_from_content.html | 50 +++++++++++++++++++++--- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/accname/name/comp_name_from_content.html b/accname/name/comp_name_from_content.html index 0b40206a7ebc9a..05fc6ba3d467ff 100644 --- a/accname/name/comp_name_from_content.html +++ b/accname/name/comp_name_from_content.html @@ -8,20 +8,60 @@ +

Tests the #comp_name_from_content portions of the AccName Name Computation algorithm.

-

label

+

This series of tests exercises the button, heading, and link elements, because each have different characteristics worthy of testing in each of the name computation algorithm scenarios:

+ + +

simple

+
+

label

+label
+
+ +

simple with ::before

+
+

label

+label
+
+ +

simple with ::after

+
+

label

+label
+
+ +

simple with ::before and ::after

+
+

label

+label
+
+ +

Starting this as an incomplete draft PR to raise an few potential issues that might be bugs or might be spec problems.

+ link + image + link + + heading + + +

heading with two nested links referencing image using aria-labelledby

+

+ + link1 + + + link2 + image + + + link3 + +

+ + + + + + +

simple w/ for each child (w/o spaces and display:inline)

+

TBD spec issue?: I think the AccName spec #comp_append requires joining even inline elements on a space.

+

Rendered content is "ThisIsBroken" but AccName requires it be exposed to Accessibilty as "T hisI sBro ken"…

+
+

ThisIsBroken

+ThisIsBroken
+
+ +

simple w/ for each child (w/o spaces and display:block)

+

Re: above spec issue, the spec behavior makes sense when rendered as block or inline-block.

+
+

onetwothree

+onetwothree
+
+ +

simple w/ for each child (w/o spaces and display:inline block)

+

Re: above spec issue, the spec behavior makes sense when rendered as block or inline-block.

+
+

onetwothree

+onetwothree
+
-Todo: test all remaining *recursive* cases in https://w3c.github.io/accname/#comp_recursive_name_from_content + ---> From 20c856f9cde622774cd340a97e76a57b09bf62df Mon Sep 17 00:00:00 2001 From: James Craig Date: Thu, 5 Oct 2023 16:16:01 -0700 Subject: [PATCH 12/15] review feedback on the arabic used --- accname/name/comp_name_from_content.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/accname/name/comp_name_from_content.html b/accname/name/comp_name_from_content.html index a9ae19a7ada896..b0110f27603226 100644 --- a/accname/name/comp_name_from_content.html +++ b/accname/name/comp_name_from_content.html @@ -26,7 +26,7 @@ content: " من قبل "; } .simple-after:dir(rtl)::after { - content: " خلف "; + content: " بعد "; } .fallback-before::before { content: " before "; @@ -90,9 +90,9 @@

-
-

طابع

- طابع
+
+

اسم

+ اسم

From 3e8042054e03e34215f37fb53efbbe01836f9dc3 Mon Sep 17 00:00:00 2001 From: James Craig Date: Thu, 5 Oct 2023 16:20:17 -0700 Subject: [PATCH 13/15] changed the arabic, but forgot to update the test expectation. shame. --- accname/name/comp_name_from_content.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accname/name/comp_name_from_content.html b/accname/name/comp_name_from_content.html index b0110f27603226..87700bea4578ec 100644 --- a/accname/name/comp_name_from_content.html +++ b/accname/name/comp_name_from_content.html @@ -90,9 +90,9 @@

-
-

اسم

- اسم
+
+

اسم

+ اسم

From 3c1c4be2cbb14e9d87f887989ece24894a5e1397 Mon Sep 17 00:00:00 2001 From: James Craig Date: Mon, 9 Oct 2023 13:46:31 -0700 Subject: [PATCH 14/15] review comments from rahimabdi --- accname/name/comp_name_from_content.html | 71 +++++++++++++++++++----- 1 file changed, 58 insertions(+), 13 deletions(-) diff --git a/accname/name/comp_name_from_content.html b/accname/name/comp_name_from_content.html index 87700bea4578ec..cac0eea2eea9c9 100644 --- a/accname/name/comp_name_from_content.html +++ b/accname/name/comp_name_from_content.html @@ -11,29 +11,42 @@