From aa5832f256a2c8fbdba7961354a2f50488ba4173 Mon Sep 17 00:00:00 2001
From: Brandon Maslen <brandm@microsoft.com>
Date: Thu, 9 Feb 2017 14:08:35 -0800
Subject: [PATCH 1/3] Fetch KeepAlive Quota Tests

Initial add of quota tests for keepalive fetch requests.
---
 .../api/request/request-keepalive-quota.html  | 93 +++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 fetch/api/request/request-keepalive-quota.html
diff --git a/fetch/api/request/request-keepalive-quota.html b/fetch/api/request/request-keepalive-quota.html
new file mode 100644
index 00000000000000..9115d3faf2f275
--- /dev/null
+++ b/fetch/api/request/request-keepalive-quota.html
@@ -0,0 +1,93 @@
+﻿<!doctype html>
+<html>
+    <head>
+        <meta charset="utf-8">
+        <title>Request Keepalive Quota Tests</title>
+        <meta name="help" href="https://fetch.spec.whatwg.org/#request">
+        <meta name="help" href="https://fetch.spec.whatwg.org/#body-mixin">
+        <meta name="author" title="Microsoft Edge" href="https://www.microsoft.com">
+        <meta name="timeout" content="long">
+        <script src="../../../resources/testharness.js"></script>
+        <script src="../../../resources/testharnessreport.js"></script>
+    </head>
+    <body>
+        <script>
+            "use strict";
+
+            // We want to ensure that our keepalive requests hang slightly before completing so we can validate
+            // the effects of a rolling quota. To do this we will utilize trickle.py with a 1s delay. This should
+            // prevent any of the Fetch's from finishing in this window.
+            var trickleURL = "../resources/trickle.py?count=1&ms=";
+            var standardDelay = 1000;
+
+            // We should expect 64KB of rolling quota for any type of keep-alive request sent.
+            var expectedQuota = 65536;
+
+            function CreateKeepAliveRequest(delay, bodySize) {
+                // Create a body of the specified size that's filled with *'s
+                var requestBody = Array(bodySize).fill('*').join("");
+                return new Request(trickleURL+delay, {keepalive: true, body: requestBody, method: "POST"});
+            }
+
+            // Test 1 Byte
+            promise_test(function(test) {
+                return fetch(CreateKeepAliveRequest(0 /* delay */, 1 /* bodySize */));
+            }, "A Keep-Alive fetch() with a small body should succeed.");
+
+            // Test Quota full limit
+            promise_test(function(test) {
+                return fetch(CreateKeepAliveRequest(0 /* delay */, expectedQuota));
+            }, "A Keep-Alive fetch() with a body at the Quota Limit should succeed.");
+
+            // Test Quota + 1 Byte
+            promise_test(function(test) {
+                return promise_rejects(test, new TypeError(), fetch(CreateKeepAliveRequest(0 /* delay */, expectedQuota + 1)));
+            }, "A Keep-Alive fetch() with a body over the Quota Limit should reject.");
+
+            // Test the Quota becomes available upon promise completion.
+            promise_test(function (test) {
+                // Fill our Quota then try to send a second fetch.
+                var firstFetch = fetch(CreateKeepAliveRequest(standardDelay, expectedQuota)).then(function(response) {
+                    // Now validate that we can send another Keep-Alive fetch for the full size of the quota.
+                    return fetch(CreateKeepAliveRequest(0 /* delay */, expectedQuota));
+                });
+
+                return firstFetch;
+            }, "A Keep-Alive fetch() should return it's allocated Quota upon promise resolution.");
+
+            // Ensure only the correct amount of Quota becomes available when a fetch completes.
+            promise_test(function(test) {
+                var lastFetchSucceeded = false;
+                // Create a fetch that uses all but 1 Byte of the Quota and runs for 2x as long as the other requests.
+                var firstFetch = fetch(CreateKeepAliveRequest(standardDelay * 2, expectedQuota - 1)).then(function(response) {
+                    // This should be our last completing fetch(). We need to validate that the last fetch we sent out actually
+                    // completed.
+                    assert_true(lastFetchSucceeded, "Out last fetch after gaining Quota back should have succeeded.");
+                });
+
+                // Now create a single Byte request that will complete quicker.
+                fetch(CreateKeepAliveRequest(standardDelay, 1 /* bodySize */)).then(function(response) {
+                    // We shouldn't be able to create a 2 Byte request right now as only 1 Byte should have freed up.
+                    assert_throws(new TypeError(), fetch(CreateKeepAliveRequest(0 /* delay */, 2 /* bodySize */)), "Only 1 Byte of Quota should be available right now.");
+
+                    // Now validate that we can send another Keep-Alive fetch for just 1 Byte.
+                    fetch(CreateKeepAliveRequest(0 /* delay */, 1 /* bodySize */)).then(function(response) {
+                        // Flag we got a response from this request.
+                        lastFetchSucceeded = true;
+                    });
+                });
+
+                return firstFetch;
+            }, "A Keep-Alive fetch() should return only it's allocated Quota upon promise resolution.");
+
+            // Test rejecting a fetch() after the quota is used up.
+            promise_test(function (test) {
+                // Fill our Quota then try to send a second fetch.
+                fetch(CreateKeepAliveRequest(standardDelay, expectedQuota));
+
+                return promise_rejects(test, new TypeError(), fetch(CreateKeepAliveRequest(0 /* delay */, 1 /* bodySize */)));
+            }, "A Keep-Alive fetch() should not be allowed if the Quota is used up.");
+
+        </script>
+    </body>
+</html>

From e859ac4564fafffb5bfcba42f1f9d81e9fe22e89 Mon Sep 17 00:00:00 2001
From: Brandon Maslen <brandm@microsoft.com>
Date: Thu, 9 Feb 2017 15:01:24 -0800
Subject: [PATCH 2/3] Updating Testharness Path To Be Absolute

---
 fetch/api/request/request-keepalive-quota.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fetch/api/request/request-keepalive-quota.html b/fetch/api/request/request-keepalive-quota.html
index 9115d3faf2f275..255bf7090626e2 100644
--- a/fetch/api/request/request-keepalive-quota.html
+++ b/fetch/api/request/request-keepalive-quota.html
@@ -7,8 +7,8 @@
         <meta name="help" href="https://fetch.spec.whatwg.org/#body-mixin">
         <meta name="author" title="Microsoft Edge" href="https://www.microsoft.com">
         <meta name="timeout" content="long">
-        <script src="../../../resources/testharness.js"></script>
-        <script src="../../../resources/testharnessreport.js"></script>
+        <script src="/resources/testharness.js"></script>
+        <script src="/resources/testharnessreport.js"></script>
     </head>
     <body>
         <script>

From e2e1045f4e0b72968ddf950b69e1dfca8ff1d120 Mon Sep 17 00:00:00 2001
From: Brandon Maslen <brandm@microsoft.com>
Date: Mon, 13 Feb 2017 13:35:08 -0800
Subject: [PATCH 3/3] Cleaning up tests based on feedback.

---
 fetch/api/request/request-keepalive-quota.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fetch/api/request/request-keepalive-quota.html b/fetch/api/request/request-keepalive-quota.html
index 255bf7090626e2..dacc63826672d2 100644
--- a/fetch/api/request/request-keepalive-quota.html
+++ b/fetch/api/request/request-keepalive-quota.html
@@ -20,12 +20,12 @@
             var trickleURL = "../resources/trickle.py?count=1&ms=";
             var standardDelay = 1000;
 
-            // We should expect 64KB of rolling quota for any type of keep-alive request sent.
+            // We should expect 64KiB of rolling quota for any type of keep-alive request sent.
             var expectedQuota = 65536;
 
             function CreateKeepAliveRequest(delay, bodySize) {
                 // Create a body of the specified size that's filled with *'s
-                var requestBody = Array(bodySize).fill('*').join("");
+                var requestBody = "*".repeat(bodySize);
                 return new Request(trickleURL+delay, {keepalive: true, body: requestBody, method: "POST"});
             }
 
