From d37d1875de3e025e7e4caa0048905f63962317ef Mon Sep 17 00:00:00 2001 From: Frankie Date: Tue, 16 Mar 2021 08:40:33 -1000 Subject: [PATCH] use posinstall to do deprecation warnings (#3917) * use posinstall to do deprecation warnings * add to change log * add preinstall warning * remove preinstall * add warnings to bzz and shh package.json Co-authored-by: Wyatt Barnes --- CHANGELOG.md | 1 + packages/web3-bzz/package.json | 3 ++- packages/web3-bzz/src/index.js | 4 ---- packages/web3-shh/package.json | 3 ++- packages/web3-shh/src/index.js | 3 --- packages/web3/package.json | 3 ++- 6 files changed, 7 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a94250ca96..9fd71a90009 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -361,5 +361,6 @@ Released with 1.0.0-beta.37 code base. ### Changed - Unified babel compiler for `web3-eth2-core` and `web3-eth2-beaconchain` (#3892) +- moved deprecation warnings to postinstall scripts (#3917) - Upgrade `@chainsafe/geth-dev-assistant` from `0.1.5` to `0.1.9` (#3950) - Replaced hardcoded infura link with Github Secret for some tests (#3943) diff --git a/packages/web3-bzz/package.json b/packages/web3-bzz/package.json index d52890ede1d..4c3db40d729 100644 --- a/packages/web3-bzz/package.json +++ b/packages/web3-bzz/package.json @@ -10,7 +10,8 @@ "types": "types/index.d.ts", "scripts": { "tsc": "tsc -b tsconfig.json", - "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types" + "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types", + "postinstall": "echo \"WARNING: the web3-bzz api will be deprecated in the next version\"" }, "main": "lib/index.js", "dependencies": { diff --git a/packages/web3-bzz/src/index.js b/packages/web3-bzz/src/index.js index 56cd0fe0230..7f87381f838 100644 --- a/packages/web3-bzz/src/index.js +++ b/packages/web3-bzz/src/index.js @@ -28,10 +28,6 @@ var swarm = require("swarm-js"); var Bzz = function Bzz(provider) { - - console.warn('web3-bzz package will be deprecated in version 1.3.5 and will no longer be supported.') - - this.givenProvider = Bzz.givenProvider; if (provider && provider._requestManager) { diff --git a/packages/web3-shh/package.json b/packages/web3-shh/package.json index a41518b7a95..53ce7ef1e18 100644 --- a/packages/web3-shh/package.json +++ b/packages/web3-shh/package.json @@ -10,7 +10,8 @@ "types": "types/index.d.ts", "scripts": { "tsc": "tsc -b tsconfig.json", - "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types" + "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types", + "postinstall": "echo \"WARNING: the web3-shh api will be deprecated in the next version\"" }, "main": "lib/index.js", "dependencies": { diff --git a/packages/web3-shh/src/index.js b/packages/web3-shh/src/index.js index e1e893aaf1b..0a7b425d77c 100644 --- a/packages/web3-shh/src/index.js +++ b/packages/web3-shh/src/index.js @@ -32,9 +32,6 @@ var Net = require('web3-net'); var Shh = function Shh() { - console.warn('web3-shh package will be deprecated in version 1.3.5 and will no longer be supported.') - - var _this = this; // sets _requestmanager diff --git a/packages/web3/package.json b/packages/web3/package.json index dac5f9a4467..4860aa461cb 100644 --- a/packages/web3/package.json +++ b/packages/web3/package.json @@ -20,7 +20,8 @@ "types": "types/index.d.ts", "scripts": { "tsc": "tsc -b tsconfig.json", - "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types" + "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types", + "postinstall": "echo \"WARNING: the web3-shh and web3-bzz api will be deprecated in the next version\"" }, "authors": [ {