Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move types to devDependency. #2965

Closed
MicahZoltu opened this issue Jul 23, 2019 · 0 comments · Fixed by #3453
Closed

Move types to devDependency. #2965

MicahZoltu opened this issue Jul 23, 2019 · 0 comments · Fixed by #3453
Labels
2.x 2.0 related issues Types Incorrect or missing types

Comments

@MicahZoltu
Copy link

https://github.com/ethereum/web3.js/blob/12361e5f04bac0df10e3dbd7a6d57a86677cf0d7/packages/web3/package.json#L64

Recommend moving @types/node to a devDependency. It isn't needed at runtime, and if a library user is is targeting browser this dependency will give them incorrect type hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x 2.0 related issues Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
2 participants
@MicahZoltu @nivida