Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure filtering works for strings on events #5807

Closed
2 tasks done
nikoulai opened this issue Feb 3, 2023 · 2 comments · Fixed by #6167
Closed
2 tasks done

Ensure filtering works for strings on events #5807

nikoulai opened this issue Feb 3, 2023 · 2 comments · Fixed by #6167
Assignees
@spacesailor24
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@nikoulai
Copy link
Contributor

nikoulai commented Feb 3, 2023

This is not a Bug Report, Feature Request, or related to Documentation

  • I have searched the existing issues

Is there an existing issue for this?

  • I have searched the existing issues

What's up?

In 1.x seems that there is a bug and strings cannot be used to filter indexed events

Example

contract.events.MyEvent({filter: {a: "string"}})

We should ensure that this works on 4.x

Examples/References

Reported lately: #5806
Initial issue: #3053
@nikoulai nikoulai added the 4.x 4.0 related label Feb 3, 2023
@spacesailor24 spacesailor24 added the Bug Addressing a bug label Mar 29, 2023
@spacesailor24 spacesailor24 self-assigned this Jun 6, 2023
@spacesailor24
Copy link
Contributor

Currently in 4.x, filtering of non-indexed events arguments does not work. Instead all the events are returned

@spacesailor24
Copy link
Contributor

In addition to this, filtering of indexed strings was not supported

@spacesailor24 spacesailor24 mentioned this issue Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacesailor24 spacesailor24

Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Event filtering using non/indexed string arguments web3/web3.js
2 participants
@nikoulai @spacesailor24