Skip to content
This repository has been archived by the owner on Mar 5, 2025. It is now read-only.

Version 19.0 no longer supports BigNumber objects in contract methods #925

Closed
D-Nice opened this issue Jul 17, 2017 · 4 comments
Closed
Labels
Bug Addressing a bug

Comments

@D-Nice
Copy link

D-Nice commented Jul 17, 2017

It appears that the latest update has broken contract methods, which are directly passed BigNumber objects now, from the following release change:
Checks for the right argument number in contract functions

The error returned when passing a formerly working function, with a BigNumber as a parameter is:
Error: Invalid number of arguments to Solidity function

Reverting to 18.2 or calling .valueOf() on the BigNumber parameter is a temporary patch, but I believe this should be fixed, as it states in the web3 API doc that the BigNumber type is a valid parameter to pass directly!

This issue was previously brought up on metamask MetaMask/metamask-extension#1778

@frozeman frozeman added Bug Addressing a bug help wanted labels Jul 24, 2017
@frozeman
Copy link
Contributor

Is this still an issue in 0.20.0?

@D-Nice
Copy link
Author

D-Nice commented Jul 24, 2017

I haven't tried with 0.20.0 but will give it a try when able, but I think I've seen some fix potentially implemented back in 0.19.1 so I'll report back on those results.

@D-Nice
Copy link
Author

D-Nice commented Sep 13, 2017

To report back, this is broken in 19.0, but other versions appear fine.

@frozeman
Copy link
Contributor

We are focusing on the 1.0 branch, can you make sure that issue doesnt exist there?, also please re-test with 0.20.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

2 participants