Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal Finder does not work with Lightning Core #47

Open
grasmash opened this issue Sep 12, 2019 · 1 comment
Open

Drupal Finder does not work with Lightning Core #47

grasmash opened this issue Sep 12, 2019 · 1 comment

Comments

@grasmash
Copy link

grasmash commented Sep 12, 2019

When Lightning Core is installed at docroot/modules/contrib/lightning_core and $this=>locateRoot('docroot/modules/contrib/lightning_core') is executed, Drupal Finder will incorrectly assume that docroot/modules/contrib/lightning_core is actually the root.

This is due to Lightning Core's composer.json, which contains entries for installer-paths.

It seems like it would be useful to add a couple of extra checks to Drupal Finder ensure that the directory structure looks like Drupal core. For instance, checking for core,index.php,modules, etc. Checking values in composer.json is not sufficient in all cases.

@simesy
Copy link

simesy commented Sep 16, 2019

File link to composer.json not working for me. I assume this one is the same https://git.drupalcode.org/project/lightning_core/blob/8.x-1.x/composer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants