Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract webjar-enabled require.js method and webjar scanning into own artifact #23

Open
magro opened this issue Sep 4, 2013 · 4 comments
Assignees

Comments

@magro
Copy link

magro commented Sep 4, 2013

In the webjars-locator repo I've already asked for a require.js webjars loader webjars/webjars-locator#24.
In the meantime I'm thinking that it would make sense to extract webjars scanning and the require.js webjars loader into its own module/artifact so that this can be reused by different projects. This would reduce code duplication, things wouldn't be reinvented again and again.
I'm asking here because I'd think that the mentioned functionality would be extracted from webjars-play.

What do you think?

@magro
Copy link
Author

magro commented Sep 6, 2013

Any feedback?

@ghost ghost assigned huntc Oct 8, 2013
@jamesward
Copy link
Member

Yeah. This makes sense. @huntc is assigned. Sorry for the delay in responding.

@magro
Copy link
Author

magro commented Oct 9, 2013

Thanx anyway :-) Btw, while it might be appealing to implement it in scala (and which would be the natural choice when the functionality is extracted from this project), as a consequence this would pull in the scala library into java projects, which is not optimal. Probably you'd be considering this anyway :-)

@huntc
Copy link
Contributor

huntc commented Oct 10, 2013

Indeed, should be Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants