-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't seem to compress HTML from html-webpack-plugin #30
Comments
worth checking if changing test: /\.js$|\.html$/,
minRatio: 0, |
hmm actually I am getting this problem too now - intermittently. |
is this a plugin ordering issue? Is there a race between the HTML plugin and the compression plugin? |
Ran into a similar problem here: markdalgleish/static-site-generator-webpack-plugin#44. There's also a related discussion going on here: jantimon/html-webpack-plugin#142. |
This issue could be solved on the level of the compression-webpack-plugin - who is maintaining this plugin right now? |
If it helps, I had the same issue and created a plugin that does this. Edit: Seems like this is now going to be implemented in compression-webpack-plugin. Deleted previously mentioned repository. |
@jantimon Can you explain how compression-webpack-plugin could solve the issue ? |
@michael-ciniawsky if I understand correctly, this would also be solved by #45. It's the same problem. |
@michael-ciniawsky there is an event fired by the html-webpack-plugin which could be used |
I'm not exactly sure, but I have an issue that's maybe caused by the same root. In my app I use CommonChunksPlugin to generate various bundle files including a manifest file like mentioned in the docs. For the bundle files the compression works just fine. But the manifest file isn't compressed. Might that be the same root cause? |
@r3dDoX Please provide more info on this + show some code 😛 |
@michael-ciniawsky Sorry, didn't see the notification. Yeah so my webpack config basically looks like this:
This results in a vendor.[hash].js.gz and a main.[hash].js.gz, but only a manifest.[hash].js and no manifest.[hash].js.gz. |
As just @r3dDoX comments, the same situation happened to me while I was setting up my bundling configuration.
As can be seen in the extract of my bundle output, only main and vendor files got a gzipped version through compression-webpack-plugin. Is there a way to tell compression-webpack-plugin to also create this file, or is it not relevant enough? In that case, I'll have to make some exceptions in my server application just for this file to be served without gzip encoding though. |
@NeaSTDL That's exactly the workaround that I've been using since then... |
No description provided.
The text was updated successfully, but these errors were encountered: