fix: improve perf #235
Merged
fix: improve perf #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
fix-improve-loading-time
branch
from
787b748 to
8eaf104
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 95.91% 96.09% +0.18%
==========================================
Files 3 3
Lines 269 282 +13
Branches 107 111 +4
==========================================
+ Hits 258 271 +13
Misses 11 11
☔ View full report in Codecov by Sentry. |
|
👍 |
stof
reviewed
Jun 14, 2023
| @@ -153,6 +151,40 @@ const { minify: minifyWorker } = require("./minify"); | |||
|
|
|||
| const warningRegex = /\s.+:+([0-9]+):+([0-9]+)/; | |||
|
|
|||
| /** | |||
| * @template T | |||
| * @param fn {(function(): any) | undefined} | |||
There was a problem hiding this comment.
shouldn't this be @param {function (): T} fn instead ? This would allow typescript to infer T properly. Also, the argument should not be undefined as that would break. The current signature means that type checking won't catch mistakes (the need to override the type when using the variable hides the fact that the type checker cannot trust it)
There was a problem hiding this comment.
@stof Good catch, feel free to send a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Avoid loading a lot of modules on initial load + lazy loading + faster tracing source maps
Breaking Changes
No
Additional Info
No