Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when using lintDirtyModulesOnly and webpack 5.beta0 #187

Closed
thasmo opened this issue Oct 11, 2019 · 2 comments · Fixed by #199
Closed

Crashes when using lintDirtyModulesOnly and webpack 5.beta0 #187

thasmo opened this issue Oct 11, 2019 · 2 comments · Fixed by #199

Comments

@thasmo
Copy link

thasmo commented Oct 11, 2019

Expected Behavior

Does not crash on successive webpack builds in watch mode.

Actual Behavior

Crashes on successive webpack builds in watch mode; not on the initial watch build tho.

Call Stack

TypeError: Cannot read property 'entries' of undefined
at LintDirtyModulesPlugin.getChangedFiles (C:\Users\user\Projects\project\node_modules\stylelint-webpack-plugin\dist\LintDirtyModulesPlugin.js:53:56)
at LintDirtyModulesPlugin.apply (C:\Users\user\Projects\project\node_modules\stylelint-webpack-plugin\dist\LintDirtyModulesPlugin.js:34:31)
at compiler.hooks.emit.tapAsync (C:\Users\user\Projects\project\node_modules\stylelint-webpack-plugin\dist\index.js:38:19)
at _next1 (eval at create (C:\Users\user\Projects\project\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:56:1)
at _err1 (eval at create (C:\Users\user\Projects\project\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:82:1)
at WebpackAssetsManifest.handleEmit (C:\Users\user\Projects\project\node_modules\webpack-assets-manifest\src\WebpackAssetsManifest.js:486:5)
at Hook.eval [as callAsync] (eval at create (C:\Users\user\Projects\project\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:78:1)
at Compiler.emitAssets (C:\Users\user\Projects\project\node_modules\webpack\lib\Compiler.js:536:19)
at process.nextTick (C:\Users\user\Projects\project\node_modules\webpack\lib\Watching.js:75:21)
at process._tickCallback (internal/process/next_tick.js:61:11)

How Do We Reproduce?

Use webpack 5.beta0 and stylelint-webpack-plugin with the lintDirtyModulesOnly option enabled and run webpack in watch mode and after the initial build, change a file which should trigger a rebuild - this time the plugin will crash.

Environment

  • OS: Windows 10
  • Node: 10
  • NPM: 6.11
  • webpack: 5.beta0
  • stylelint-webpack-plugin: 1.0.2
@thasmo thasmo changed the title Crashes when using lintDirtyModulesOnly and webpack 5.beta1 Crashes when using lintDirtyModulesOnly and webpack 5.beta0 Oct 12, 2019
@vankop
Copy link

vankop commented Oct 12, 2019

I will take a look on this

@sokra
Copy link
Member

sokra commented Oct 14, 2019

compilation.fileTimestamps has been removed in webpack 5.

see also https://github.com/webpack/changelog-v5#compilationfilesysteminfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants