Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map sourceMap to devtool #71

Closed
stevenvachon opened this issue Feb 11, 2019 · 6 comments · Fixed by #178
Closed

Map sourceMap to devtool #71

stevenvachon opened this issue Feb 11, 2019 · 6 comments · Fixed by #178
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
3.0.0

Comments

@stevenvachon
Copy link

  • Operating System: macOS 10.14.2
  • Node Version: 10.15.0
  • NPM Version: 6.4.1
  • webpack Version: 4.29.3
  • terser-webpack-plugin Version: 1.2.2

Feature Proposal

Currently, the sourceMap option must be explicitly defined when it'd be much more convenient for it to rely on the value of Webpack's devtool option.

Feature Use Case

Less verbose config
@alexander-akait
Copy link
Member

PR welcome

@alexander-akait alexander-akait added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 12, 2019
@lakatostamas
Copy link

Can I send a PR for this one?

@alexander-akait
Copy link
Member

Yep, PR welcome

@alexander-akait alexander-akait added this to the 2.0.0 milestone May 14, 2019
@nicholascm
Copy link

nicholascm commented May 23, 2019 •
edited
Loading

@evilebottnawi I have a branch with this change that is working for my use case, just working on tests: master...nicholascm:set-sourcemap-based-on-webpack-config . I ran into this issue while trying to configure the terser plugin and generate sourceMaps.

@alexander-akait
Copy link
Member

Looks good, feel free to send a PR

@nicholascm nicholascm mentioned this issue May 23, 2019
Closed
5 tasks
@alexander-akait alexander-akait mentioned this issue Sep 5, 2019
Merged
6 tasks
@alexander-akait
Copy link
Member

Partial fixed in 2.0.0 version, other fixes possible only for webpack@5

@alexander-akait alexander-akait modified the milestones: 2.0.0, 3.0.0 Sep 5, 2019
@alexander-akait alexander-akait mentioned this issue Oct 21, 2019
Merged
6 tasks
@snyk-bot snyk-bot mentioned this issue Apr 25, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jun 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
3.0.0
4 participants
@stevenvachon @alexander-akait @nicholascm @lakatostamas