This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 158
fix(package): relax node
version range (engines
)
#155
Merged
michael-ciniawsky
merged 1 commit into
webpack-contrib:master
from
lukebatchelor:lbatch/relax-engines
Oct 10, 2018
Merged
fix(package): relax node
version range (engines
)
#155
michael-ciniawsky
merged 1 commit into
webpack-contrib:master
from
lukebatchelor:lbatch/relax-engines
Oct 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
suggested changes
Oct 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just write >= 6.9.0 here
lukebatchelor
force-pushed
the
lbatch/relax-engines
branch
from
October 9, 2018 21:12
6dbb35c
to
c96d110
Compare
Thank you @evilebottnawi ! |
alexander-akait
approved these changes
Oct 9, 2018
michael-ciniawsky
changed the title
fix(package): relaxes node engines check to allow wider 8.x versions
fix(package): relax Oct 10, 2018
node
version range (engines
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukebatchelor Thx
michael-ciniawsky
pushed a commit
that referenced
this pull request
Oct 10, 2018
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Use-Case
Motivation described in #154