Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: getOptions should return an {} by default #84

Closed
michael-ciniawsky opened this issue May 10, 2017 · 0 comments
Closed

refactor: getOptions should return an {} by default #84

michael-ciniawsky opened this issue May 10, 2017 · 0 comments

Comments

@michael-ciniawsky
Copy link
Member

Currently if no loader options are set, getOptions(this) returns null by default, which requires a fallback to avoid breaking further options.x references within the loader.

const options = loaderUtils.getOptions(this)

Is that intended for some reason or would it be possible to return an empty {}by default instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant