Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer the baseDataPath option from arguments #86

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

prefer the baseDataPath option from arguments

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files           5        5           
  Lines         639      639           
  Branches      267      267           
=======================================
  Hits          627      627           
  Misses         12       12
Impacted Files Coverage Δ
src/ValidationError.js 97.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e517b...f28e161. Read the comment docs.

@alexander-akait alexander-akait merged commit e236859 into master Jan 17, 2020
@alexander-akait alexander-akait deleted the fix-prefer-baseDataPath-from-argument branch January 17, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant