Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charset in inline-source-map support #21

Merged
merged 2 commits into from
Mar 5, 2017

Conversation

PillowPillow
Copy link
Contributor

Hello, it seems that if a charset is specified in an inline source maps the loader does not detect the base64 and triggers a warning.

This PR add the support for the charset by changing a bit the regular exprssion regexDataUrl.

@jsf-clabot
Copy link

jsf-clabot commented Dec 13, 2016

CLA assistant check
All committers have signed the CLA.

@PillowPillow
Copy link
Contributor Author

PillowPillow commented Jan 3, 2017

any news?

@scamden
Copy link

scamden commented Mar 3, 2017

i have this issue too! @PillowPillow did you sign the CLA? would love to have this merged

@scamden
Copy link

scamden commented Mar 3, 2017

just to raise the urgency here, the latest release of convert-source-map (used by babel), always includes charset in the inline source map so i cannot use webpack with a current install of babel without losing source maps and getting really long warnings.

@joshwiens
Copy link
Member

@PillowPillow - You will need to close & re-open this pull request to trigger the CLA assistant if you are having trouble signing it.

The JS Foundation CLA is mandatory, reviews aside this won't merge until the CLA is signed.

@PillowPillow
Copy link
Contributor Author

@d3viant0ne I did it when i published the pr but it seems that there is a ttl. I signed it again.

@joshwiens joshwiens self-assigned this Mar 4, 2017
@joshwiens joshwiens requested review from bebraw and joshwiens March 4, 2017 08:41
Copy link
Contributor

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to me as it doesn't change existing functionality and there's a test in place.

Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looking PR @PillowPillow ( always love tests )

I am merging this now & then getting travis setup to execute the test suite.

This should make it out to npm late tonight / early tomorrow morning ( i'm GMT -6 )

@joshwiens
Copy link
Member

joshwiens commented Mar 5, 2017

For everyone's reference, if something has gone unnoticed for what you would consider an excessive time you should ping @webpack-contrib/org-maintainers which will notify all of the cross project admins so we can get it addressed.

@scamden
Copy link

scamden commented Mar 7, 2017

@d3viant0ne you mentioned this should be to npm in a couple days, i'm not seeing a release yet, any idea on timeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants