Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore package-lock.json #1251

Closed
snitin315 opened this issue Feb 22, 2020 · 1 comment · Fixed by #1252
Closed

chore: ignore package-lock.json #1251

snitin315 opened this issue Feb 22, 2020 · 1 comment · Fixed by #1252

Comments

@snitin315
Copy link
Member

snitin315 commented Feb 22, 2020 •
edited
Loading

Describe the bug

  1. As the project wokspace uses yarn it would be better to ignore package-lock.json file else beginner contributors may commit the file unknowingly.

  2. In CONTRIBUTING.md package-lock.json should be replaced with yarn.lock as well.

Screenshot from 2020-02-22 14-10-08

What is the current behavior?

git is not ignoring package-lock.json

Expected behavior
ignore package-lock.json

Additional context
I will work on this issue.
@snitin315
Copy link
Member Author

Also in CONTRIBUTING.md it says Using npm but it should be Using yarn

Screenshot from 2020-02-22 14-14-27

will fix this too.

@snitin315 snitin315 mentioned this issue Feb 22, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: ignore package-lock.json and remove its references snitin315/webpack-cli
1 participant
@snitin315