Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: master branch being reffered instead of next #1291

Closed
snitin315 opened this issue Mar 4, 2020 · 5 comments · Fixed by #1294
Closed

docs: master branch being reffered instead of next #1291

snitin315 opened this issue Mar 4, 2020 · 5 comments · Fixed by #1294

Comments

@snitin315
Copy link
Member

What is the current behavior?

Currently the default branch is next , but master branch is being refered in the docs .

Screenshot from 2020-03-04 20-36-04

Expected behavior

next branch should be refered.

Please paste the results of webpack-cli info here, and mention other relevant information

Additional context
I would like to fix it if valid.

@anshumanv
Copy link
Member

anshumanv commented Mar 4, 2020

A good candidate for initial contributions, go for it! Unless @ematipico is planning to keep this scoped for first time contributors.

@snitin315
Copy link
Member Author

I think this should be fixed soon , as it may cause some confusion for first time contributor. Like he may checkout master as per the docs.

@ematipico
Copy link
Contributor

Well I can say that this depends from the point of view. People might want to checkout master to fix important bugs for the current version.

If we change the docs now it means we will have to change the docs again once we will publish a stable version. I think a small comment in the main readme (at the beginning, where we have a quote saying that the docs refers to next version) is enough. What do you think?

@snitin315
Copy link
Member Author

Sounds Good !

@snitin315
Copy link
Member Author

We have something like this now ,
Screenshot from 2020-03-05 05-44-10

how about this @ematipico @anshumanv -

This is the documentation of the beta version (being maintained on branch next).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants