Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transformation: bannerPlugin #382

Closed
bitpshr opened this issue Apr 9, 2018 · 2 comments
Closed

Update transformation: bannerPlugin #382

bitpshr opened this issue Apr 9, 2018 · 2 comments
Labels

Comments

@bitpshr
Copy link
Member

bitpshr commented Apr 9, 2018

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
The current transformation supports migrating a webpack configuration from v1 to v2.

What is the expected behavior?
The transformation should support migrating a webpack configuration from v3 to v4.

If this is a feature request, what is motivation or use case for changing the behavior?
After some discussion the decision was made to update our migration transformations to actively support migrating only from the previous version to the current version, which currently means v3 - v4. Migrating older versions such as v1 or v2 will no longer be supported.

This feature request is to update the bannerPlugin transformation accordingly.

@evenstensberg evenstensberg added this to the Vatican (v3) milestone Apr 10, 2018
@ematipico
Copy link
Contributor

Is this changed from webpack 3 to 4? I don't think so

@matheus1lva
Copy link
Member

matheus1lva commented Apr 12, 2018

@ematipico Nop, it is not from v3 to v4.
This example was updated a long time ago. Seems that this is from v1->v2.

After double checking our transformations already does that anyways so, this can be closed, it is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants