refactor: move to yargs, use chalk #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsmanAltun
changed the title
OsmanAltun
changed the title
|
I feel this PR could be broken down into smaller ones, hard to review so many changes |
|
Forget rebasing, I don't want to break anything 😅 It is difficult to split this PR, because there are many trial/error commits. I have been using my version for quite a while (since the last commit of 2020), no issues so far. |
DiegoRBaquero
requested changes
Jun 3, 2021
DiegoRBaquero
approved these changes
Jun 8, 2021
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
## [3.3.1](v3.3.0...v3.3.1) (2021-07-09) ### Code Refactoring * move to yargs, use chalk ([#144](#144)) ([177bc48](177bc48)) ### BREAKING CHANGES * * Create new branch: revamp * Complete revamp * Added quote function * Bugfixes * Bugfixes * Replace console.log with process.stdout.write * Bugfixes * Cleanup dependencies * Added feature * Standard --fix * Update docs * Standard --fix * Fix small bug * Standard --fix * Multiple torrent downloads fix * Less hard coding * Small adjustments * Fix optiongroup order * Replace yargs with minimist wrapper * Revert commit: 94c561c * Pull changes 3.2.1 * Pull changes 3.2.1 * Fix busy port issue * Small fixes * Small changes * Small fixes * Small fixes * Small changes * Remove unnecessary complexity * Webtorrent 0.112.0 * Small fixes * Small fix * Remove clivas.flush * Revert removal * Replace Clivas with Chalk and console.log * Yargs 16.2.0 * Small fix * Small improvements * dependency fix * Yargs 17.0.1 * Update .gitignore * Update .gitignore * Add [default] to download description * Remove regions * Update .gitignore Co-authored-by: Osman Altun <[email protected]> Co-authored-by: Diego Rodríguez Baquero <[email protected]>
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Is there anyway to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[x] Bug fix
[x] New feature
[x] Other, please explain:
Project revamp. I tried both CommanderJS and Yargs. I also tried making a custom wrapper for minimist, however it took too much effort. I decided to stick with Yargs.
What changes did you make? (Give an overview)
Lots.
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
Refer to changes.