Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action support for PHP Grpc #77

Closed
huan opened this issue Jul 18, 2020 · 4 comments · Fixed by #78
Closed

Add GitHub Action support for PHP Grpc #77

huan opened this issue Jul 18, 2020 · 4 comments · Fixed by #78
Labels
enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Jul 18, 2020

#76 has added the PHP related scripts for generating the GRPC stubs in PHP, so all the PHP related code will be fully automated after we create its GitHub Action.

It will great if @zhangchunsheng can create another PR to implement it.
@huan huan added the enhancement New feature or request label Jul 18, 2020
@zhangchunsheng
Copy link
Member

I will add Github Action when I have time.

@huan
Copy link
Member Author

huan commented Jul 19, 2020

Awesome! Looking forward to adding the GitHub Action for PHP to our GRPC service!

@zhangchunsheng
Copy link
Member

I have added php action.

@zhangchunsheng zhangchunsheng mentioned this issue Aug 4, 2020
Merged
@huan huan closed this as completed in #78 Aug 5, 2020
@huan
Copy link
Member Author

huan commented Aug 5, 2020

Fantastic! Thank you very much for improving our DevOps pipeline for PHP Wechaty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add php action
2 participants
@zhangchunsheng @huan