Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: consider releasing universal Python wheels ? #7

Closed
neutrinoceros opened this issue Oct 20, 2022 · 6 comments · Fixed by #9
Closed

BLD: consider releasing universal Python wheels ? #7

neutrinoceros opened this issue Oct 20, 2022 · 6 comments · Fixed by #9

Comments

@neutrinoceros
Copy link

neutrinoceros commented Oct 20, 2022

would it be possible to publish some wheels for all three major platforms (not just windows) on PyPI ?
It may be possible to avoid making one wheel per Python version using Py_LIMITED_API

For example see how this was done in casa-formats-io: radio-astro-tools/casa-formats-io#50

@weddige
Copy link
Owner

weddige commented Oct 20, 2022

Thank you for the suggestion. I'll have a look at it (as soon as I find some time, which might take a while).

@neutrinoceros
Copy link
Author

looks like even building from source via pip is going to break at some point in the future

reproducer

python -m venv .venv
.venv/bin/activate
python -m pip install -U pip
python -m pip install miniballcpp --no-binary miniballcpp

ouptput

 DEPRECATION: miniballcpp is being installed using the legacy 'setup.py install' method,
 because it does not have a 'pyproject.toml' and the 'wheel' package is not installed.
 pip 23.1 will enforce this behaviour change.
 A possible replacement is to enable the '--use-pep517' option.
 Discussion can be found at https://github.com/pypa/pip/issues/8559

see pypa/pip#8559

If you're interested, I should be able to help with modernizing the package to these uprising standards.

@weddige
Copy link
Owner

weddige commented Nov 19, 2022

I managed to find a few minutes and added the pyproject.toml and some basic tests: #8

@neutrinoceros
Copy link
Author

Awesome, thank you ! I'm still game to help you with wheels automation (using https://cibuildwheel.readthedocs.io/en/stable/) and/or PY_LIMITED_API, just let me know if you'd like a hand !

@weddige
Copy link
Owner

weddige commented Nov 19, 2022

Thank you for the offer. I'll give it a try today and see how far I'll get. If there are issues still open after that, I'll thankfully take any PR.

@weddige weddige linked a pull request Nov 19, 2022 that will close this issue
@neutrinoceros
Copy link
Author

Thanks a lot for your work on this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants