fixes the main.predict_file for numeric labels #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrykironde
reviewed
Jan 7, 2025
There was a problem hiding this comment.
@naxatra2 Thank you for your contribution! I'm not sure if this part is necessary in the tests (test_predict_tile_with_crop_model_empty). Since the changes are focused on predict_file, I was expecting the test updates to primarily be in test_[predict]*[file].
tests/test_main.py
Outdated
| crop_model = model.CropModel() | ||
|
|
||
| # Configure the label dictionary | ||
| m.label_dict = {"Tree": 0, "Bush": 1} |
There was a problem hiding this comment.
@naxatra2 Why do we have this here?
There was a problem hiding this comment.
I accidentally committed that part, earlier I was using a different logic where I used this. I should remove this
henrykironde
added
the
Awaiting author contribution
|
I though that I did changes on |
github-actions
bot
removed
the
Awaiting author contribution
removed an unnecessary dictionary (label_dict)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
I have updated the cropmodel_label in
main.predict_file. Earlier it was showing 0 or 1, now it better matches the result["label"] from the detection as being a string.The testcases are also running.