Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: merging fails with output set to stdout #154

Closed
Cube707 opened this issue Jan 25, 2025 · 2 comments · Fixed by #157
Closed

Regression: merging fails with output set to stdout #154

Cube707 opened this issue Jan 25, 2025 · 2 comments · Fixed by #157
Assignees
@EnricoMi

Comments

@Cube707
Copy link
Contributor

Cube707 commented Jan 25, 2025 •
edited
Loading

calling something like

junitparser merge tests/data/jenkins.xml -

fails with TypeError: write() argument must be str, not bytes

This regression was introduced when merging #148 and it works fine on 260ef3d.

pretty sure the issue stems from here:

junitparser/junitparser/cli.py

Line 18 in 16c54d7

result.write(sys.stdout if output == "-" else output)

@Cube707
Copy link
Contributor Author

Cube707 commented Jan 25, 2025

CC: @EnricoMi

@Cube707 Cube707 changed the title Regression: mergin fails withou output to stdout Regression: merging fails with output set to stdout Jan 25, 2025
@Cube707 Cube707 mentioned this issue Jan 25, 2025
Merged
@Cube707
Copy link
Contributor Author

Cube707 commented Jan 25, 2025

also see https://github.com/weiwei/junitparser/actions/runs/12966613410/job/36167570796?pr=152 for details

@EnricoMi EnricoMi self-assigned this Jan 28, 2025
@EnricoMi EnricoMi mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EnricoMi EnricoMi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix write to stdout weiwei/junitparser
2 participants
@EnricoMi @Cube707