Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Add missing replacer MPs (ersättare) and MP metadata to Wikidata (from Joe's list) #305

Closed
fredrik1984 opened this issue May 25, 2023 · 16 comments
Milestone

Comments

@fredrik1984
Copy link
Collaborator

Joe Noonan has discovered 45 MP replacers (ersättare) with missing Wikidata-id or missing important metadata (chamber, dates in parliament, etc). He has created a nice CSV file of these MPs (attached here). In the column "ers_name_from_text" you find the MP replacer and in the column "mp_name" you find the (ordinarie) MP that is being replaced.

According to Joe, these 45 MP replacers were not found in our current Github .csv metadata file. @BobBorges can you check this? These 45 MPs seem to be in the bio books (in the list at the end, "Register över ej biograferade ersättare").

@salgo60: would it be possible for you to add these MPs to Wikidata + add relevant metadata?

missing_replacements_1974_1993.xlsx

@fredrik1984 fredrik1984 added this to the MP database milestone May 25, 2023
@salgo60
Copy link
Contributor

salgo60 commented May 25, 2023

Yes I can add it and I have it in my backlog to add them but if you have a csv file its easier....

I am out on a 2 days short kajak trip so I check status when I am back

image

@MansMeg

This comment was marked as resolved.

@MansMeg
Copy link
Collaborator

MansMeg commented May 25, 2023

Ah. I now saw that this us stuff we want to use for the replacement roles and including this in our metadata.

@BobBorges
Copy link
Collaborator

There are a few outstanding things I like to discuss in the meeting tomorrow relating to the PR; it seems like we haven't introduced bugs, but there's still the issue of carefully checking a sample of diffs and some other things to be fixed per the discussions on Monday along with some of the current issues here.

@salgo60
Copy link
Contributor

salgo60 commented May 30, 2023

I have started now see #115#issuecomment-1568012110

  • step 1 will be just create empty objects --> you get a Qnumber
  • then I will try to find more info about the objects

@fredrik1984 the following people I dont find in the books

  • Britt Johannesson
  • Carl Graf

@fredrik1984
Copy link
Collaborator Author

fredrik1984 commented May 30, 2023

Excellent, thank you @salgo60!

I find both Britt Johannesson and Carl Graf in the bio books. I attach a screenshot of each here. I think Graf is Carl Fredrik Graf.

Skärmavbild 2023-05-30 kl  13 43 44
Skärmavbild 2023-05-30 kl  13 47 03

@salgo60
Copy link
Contributor

salgo60 commented May 30, 2023

More my old eyes cant find

  • Olavi Väitanen

@fredrik1984
Copy link
Collaborator Author

His name is actually a Olavi Viitanen, so this is probably an OCR error.

Skärmavbild 2023-05-30 kl  14 46 04

@salgo60

This comment was marked as duplicate.

@salgo60
Copy link
Contributor

salgo60 commented May 30, 2023

image

image
  • and I guess she has an article in the book which the people doing the book maybe has missed....

  • volume 2 page 163

image image image

@salgo60
Copy link
Contributor

salgo60 commented Jun 4, 2023

@fredrik1984 version 1 is done see

@fredrik1984
Copy link
Collaborator Author

Thanks! Regarding the people that are missing in Riksdagens data, does this means that they are found in the bio books but are missing in Riksdagens öppna data?

@salgo60
Copy link
Contributor

salgo60 commented Jun 4, 2023

Thanks! Regarding the people that are missing in Riksdagens data, does this means that they are found in the bio books but are missing in Riksdagens öppna data?

Yes.....

Many WD persons has started to use the pattern when something is missing in an external identifier
we have started to use this pattern setting No Value

image image
  • "Något värde" is used when we know this person has been a substitute but we dont know the name...
image

As said I just walked through the substitute pages and added those without an asteriks


What can we trust

  1. Riksdagens data has sometimes text strings for substitute but that is rather easy to "translate" into a WD object for the person #60
  2. Robin WD user Popperipopp has added many BUT I have added the source "Enkammarriksdagen 1971-1993/94 / Q111443541" --> We can do SPARQL all from the book Enkammarriksdagen 1971-1993/94 / Q111443541 ( OBS many are missing)
image
  1. We can rather easy Google search and find documents at Riksdagen that states a person is substituted
    example:

G80958
Uppdraget som ersättare hade därigenom upphört för Gerd Mahl Karls­son, Lars-Erik Ahlinder, Torgny Larsson, Per Arne Aglert och Bror Eriksson (svenska)
Riksdagens protokoll 1984/85:58 / Q98490259

  1. I have also found that Wiki articles like Fyrstadskretsen tells substitutes but has no source (not used by me)
image

Should Riksdagens Open Data be outside this loop?

Feels odd that we dont report things back to Riksdagens Öppna data see #149

@MansMeg
Copy link
Collaborator

MansMeg commented Sep 16, 2023

I guess this has now been fixed and can be closed?

Re your question on Riksdagens öppna data, that is a separate issue we will do as a quality control, i.e. look at differences between RÖD and our MP database.

@salgo60
Copy link
Contributor

salgo60 commented Sep 16, 2023

I have done the WD part and added an issue to Riksdagens "skuggbacklog" #158

@MansMeg
Copy link
Collaborator

MansMeg commented Sep 16, 2023

Excellent!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants