Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed relative motion vectors #395

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

quantenschaum
Copy link
Contributor

fixes #394

@wellenvogel
Copy link
Owner

I cannot accept the PR as you changed the tests for drawing relative motion vectors.
There are 2 style properties:
style.courseVector (true|false)
style.courseVectorColor (color)
See https://www.wellenvogel.net/software/avnav/docs/hints/usericons.html?lang=en#h2:AISImages
For testing whether to draw vectors the first one must be used.
I guess we even would have to check if "useCourseVector" is active at all (basically disabling this could improve the performance on very slow displays).

@quantenschaum
Copy link
Contributor Author

OK, now I understand the somewhat strange expression style.courseVector !== false because courseVector can be (and is) undefined. The breaking change was, that target.distance now is in meters.

@quantenschaum
Copy link
Contributor Author

I adjusted the conditions to check for useCourseVector && style.courseVector !== false first.

@quantenschaum
Copy link
Contributor Author

in current master the aisRelativeMotionVectorRange is missing.

image

A typo, fixed it in 839e30f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative motion vectors are not displayed
2 participants