Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Beta Testing #97

Closed
wesbos opened this issue Sep 7, 2021 · 6 comments
Closed

2.0 Beta Testing #97

wesbos opened this issue Sep 7, 2021 · 6 comments

Comments

@wesbos
Copy link
Owner

wesbos commented Sep 7, 2021

If anyone wants to test the latest version of this eslint on your project, please do!

There aren't many rule changes, but it's all updated for the latest packages and has support for typescript.

  1. In your project run npx install-peerdeps --dev [email protected]
  2. In yout .eslintrc file, use { extends: "wesbos" } for JS, or { extends: "wesbos/typescript" } for TS
  3. For JS, you might need a .babelrc file with {} in it, let me know if you do

Let me know if there are any issues. Would like to get this sucker shipped as the current one is clashing with a few libs.

@wesbos wesbos mentioned this issue Sep 7, 2021
@islami00
Copy link

islami00 commented Sep 7, 2021

Currently testing beta11
Everything is working fine, had a hard time with prettier so I installed the eslint-prettier extension. .

Edit: not necessary. after some more tinkering, I realized all I had to do was disable the regular prettier extension for ts and tsx like this , to avoid conflicts with eslint.
Formats properly on save and all.

The only issue right now is the no-use-before-define error on import React from 'react'
Fixed it by enabling only the @typescript-eslint version of the rule:

{
    "no-use-before-define": 0,
    "@typescript-eslint/no-use-before-define": 1
}

Got the final answer here

@wesbos
Copy link
Owner Author

wesbos commented Sep 8, 2021

@islami00 thanks, you shouldn't have to install eslint-prettier. Will have a look into it! Will also check those rules

@GPorter43
Copy link

Using Windows 10 and had to have a Babelrc file with empty brackets for js files. let me know if you need anything to debug

@wesbos
Copy link
Owner Author

wesbos commented Sep 9, 2021

Thanks! I'm just looking and I thinkI can avoid that with requireConfigFile. Will try it

https://github.com/babel/babel/tree/main/eslint/babel-eslint-parser#additional-parser-configuration

@wesbos
Copy link
Owner Author

wesbos commented Sep 9, 2021

Yep that did it! No need for the empty babel file now. Thanks again

@wesbos
Copy link
Owner Author

wesbos commented Sep 9, 2021

2.0.0 is out! Let me knwo if you hit anything else!

@wesbos wesbos closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants