New Crowdin updates #605
New Crowdin updates #605
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request adds a new node entry named Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (13)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
data/zh/solNodes.json (1)
2232-2237: Localization Consistency CheckIn the Chinese locale file, other planet names are localized (e.g., "Aphrodite (金星)" for Venus). Please verify if
"Fortuna (Venus)"should retain the English "Venus" or be adjusted (for example, to "Fortuna (金星)") to maintain consistency across entries.data/pl/solNodes.json (1)
2233-2237: Add new node "SolarisUnitedHub1" (Polish).
The new entry is correctly added with"value": "Fortuna (Venus)","enemy": "Corpus", and"type": "Relay", aligning with the intended consistency across locales. Additionally, note that a trailing newline was removed as part of this change; although this is a minor formatting adjustment, you may want to standardize on including a newline at the end of JSON files if that is the project convention.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
data/cs/solNodes.json(1 hunks)data/de/solNodes.json(1 hunks)data/es/solNodes.json(1 hunks)data/fr/solNodes.json(1 hunks)data/it/solNodes.json(1 hunks)data/ko/solNodes.json(1 hunks)data/pl/solNodes.json(1 hunks)data/pt/solNodes.json(1 hunks)data/ru/solNodes.json(1 hunks)data/sr/solNodes.json(1 hunks)data/tr/solNodes.json(1 hunks)data/uk/solNodes.json(1 hunks)data/zh/solNodes.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (12)
data/zh/solNodes.json (1)
2232-2237: New Node Entry "SolarisUnitedHub1" Correctly AddedThe new node is added with the expected fields:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "中继站"This entry is consistent with the overall JSON structure and format, and the added newline at the end of the file improves file formatting.
data/ko/solNodes.json (1)
2232-2237: New Node Entry Added Correctly (Korean Localization)
The new node entry"SolarisUnitedHub1"has been added with the expected properties:
"value": "Fortuna (Venus)""enemy": "코퍼스""type": "릴레이"This entry follows the same formatting and localization style as the other nodes in the file. No issues were detected.
data/tr/solNodes.json (1)
2227-2237: New Node Entry Added Correctly (Turkish Localization)
The new"SolarisUnitedHub1"entry is consistently added with the corresponding localized values:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "Relay"Additionally, note that there is a minor change in the file’s trailing format (a newline removal), which is acceptable unless a trailing newline is required by your formatter or linter.
data/ru/solNodes.json (1)
2233-2237: Add new localized node "SolarisUnitedHub1" (Russian).
The new entry is correctly introduced with a proper localized value ("Fortuna (Venus)"), enemy ("Корпус") and type ("Реле"). The format is consistent with the other nodes in this file.data/it/solNodes.json (1)
2232-2237: New Node Entry "SolarisUnitedHub1" Added Consistently
The new node is introduced with the expected properties:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "Relay"The formatting is consistent with the rest of the file and aligns with the coordinated changes across locale-specific files. Please verify that this entry meets the localized content requirements.
data/sr/solNodes.json (1)
2232-2237: New Node Entry "SolarisUnitedHub1" Inserted Correctly in Serbian JSON
The new entry appears with the expected properties and correct formatting. Note that the structural adjustment (removing the previous closing brace) has been handled properly to accommodate the new node. Ensure that the localized content (if any) is accurate for the Serbian locale.data/cs/solNodes.json (1)
2228-2237: New Node Addition and Formatting (English Locale)The new node
"SolarisUnitedHub1"has been correctly added with the expected properties:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "Relay"The block is placed at the end of the JSON structure, and the final closing brace (with the newline) adheres to proper JSON formatting practices.
data/uk/solNodes.json (1)
2227-2237: New Node Addition and Localization (Ukrainian Locale)The new node
"SolarisUnitedHub1"is integrated with localized values:
"value": "Фортуна (Венера)""enemy": "Корпус""type": "Реле"These changes meet the Crowdin update objectives by providing the correct localized strings, and the overall JSON structure (including the newline at the end) is maintained properly.
data/de/solNodes.json (1)
2232-2236: New Node Addition Consistency (German Locale)
The new node"SolarisUnitedHub1"is added correctly with the properties"value","enemy", and"type". The"type"value is set to"Relais", which is consistent with the German language conventions used in this file. Please verify that this entry aligns with your overall data strategy.data/pt/solNodes.json (1)
2232-2236: New Node Addition Consistency (Portuguese Locale)
The addition of the"SolarisUnitedHub1"node in this file is implemented correctly. The properties"value": "Fortuna (Venus)","enemy": "Corpus", and"type": "Relay"match the intended values for the Portuguese locale. Ensure that this matches the expected naming and translation conventions according to your localization requirements.data/fr/solNodes.json (1)
2228-2237: New French Hub Entry Added Correctly
The new entry"SolarisUnitedHub1"is added with the values:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "Relai"This is consistent with the French localization (using "Relai" for a relay node) and maintains proper JSON structure and formatting.
data/es/solNodes.json (1)
2227-2237: New Spanish Hub Entry Added Correctly
The new entry"SolarisUnitedHub1"is introduced with:
"value": "Fortuna (Venus)""enemy": "Corpus""type": "Repetidor"This matches the intended Spanish translation for a relay node and is formatted consistently with the rest of the file.
|
Code Climate has analyzed commit 5aa6cbd and detected 0 issues on this pull request. View more on Code Climate. |
|
🎉 This PR is included in version 2.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit