-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new baro items and universal medellion langs #608
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Code Climate has analyzed commit 3790192 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
data/languages.json (1)
68-79
: Review of Hunk 2: New Ship Decoration Entries
The additions for ship decorations ("/Lotus/StoreItems/Types/Items/ShipDecos/LisetPropCleaningDroneDuviri"
and"/Lotus/StoreItems/Types/Items/ShipDecos/LisetPropCorpusBasilisk"
) have been inserted with the appropriate value strings. Verify that the spelling (e.g., “Domestik Dais Drone”) and naming conventions match the design specifications.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
data/languages.json
(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (6)
data/languages.json (6)
29-37
: Review of Hunk 1: New Projection Item Addition
The new JSON entry for the projection item ("/Lotus/StoreItems/Types/Game/Projections/T4VoidProjectionBaroAkmagnusPrimeBronze"
) is correctly formatted and consistent with the file’s overall structure. Ensure that the display name"Axi M5 Relic"
complies with the intended in-game naming conventions.
95-112
: Review of Hunk 3: Additional Ship Deco and Music Item
The new JSON entries for"/Lotus/StoreItems/Types/Items/ShipDecos/TarotCardTennoConJ"
with value"Deimos Kymaeros Prex"
and"/Lotus/StoreItems/Types/Items/SongItems/LotusEatersSongItem"
with value"The Lotus Eaters Login Music"
are correctly introduced. Their formatting is consistent and meets the expected schema.
134-142
: Review of Hunk 4: Cosmetic Enhancer Update
The entry for"/Lotus/StoreItems/Upgrades/CosmeticEnhancers/Peculiars/EvilSpiritMod"
with the value"Peculiar Audience"
has been added correctly. The overall structure remains consistent.
194-217
: Review of Hunk 5: New Clan and Infestation Skin Items
The new entries for clan emblems (keys such asCNY2022EmblemItem
,CNY2023EmblemItem
,CNY2025SnakeEmblem
, andDragon2024BadgeItem
) as well as the infestation skin ("/Lotus/StoreItems/Upgrades/Skins/Infestation/NidusAlternateSkin"
) are well formatted and follow the established naming pattern. Confirm that each value (for example,"Lunar Renewal Tiger Emblem"
) exactly matches the expected in-game text.
239-265
: Review of Hunk 6: Additional Cosmetic Upgrades for Scarves, Sentinels, and Sigils
The newly introduced entries for scarves ("/Lotus/StoreItems/Upgrades/Skins/Scarves/NezhaLeverianCape"
), sentinel tails ("/Lotus/StoreItems/Upgrades/Skins/Sentinels/Tails/GaussSentinelTail"
), and sigils (including"/Lotus/StoreItems/Upgrades/Skins/Sigils/1999DrippySigil"
,"/Lotus/StoreItems/Upgrades/Skins/Sigils/WeGameNewYearFreeTigerSigil"
, and"/Lotus/StoreItems/Upgrades/Skins/Sigils/WeGameNewYearOxSigil"
) are consistent with the file’s formatting standard. Please double-check that the descriptive text (e.g.,"Lunar Renewal Tiger Sigil"
) exactly conveys the intended meaning.
329-337
: Review of Hunk 7: New Syndicate Dog Tag Entry
The addition of the syndicate dog tag item ("/Lotus/Types/Items/SyndicateDogTags/UniversalSyndicateDogTag"
) with the value"Universal Medallion"
looks correct and is consistent with the other entries. Confirm that this string entry is aligned with the design objectives stated in the PR.
🎉 This PR is included in version 2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
Universal Medallion
Reproduction steps
Evidence/screenshot/link to line
Considerations
Summary by CodeRabbit