Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new baro items and universal medellion langs #608

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented Feb 21, 2025

What did you fix?

  • new baro item strings
  • new string for Universal Medallion

Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? Yes
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? No
  • Is is a bug fix, feature request, or enhancement? Enhancement

Summary by CodeRabbit

  • New Features
    • Expanded in-game store content with a diverse range of new decorative items and projections.
    • Introduced fresh ship adornments and exclusive cosmetic upgrades to enhance personalization.
    • Added new clan emblems, alternative skins, sigils, and unique accessory items to enrich your gameplay experience.

@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) February 21, 2025 20:59
Copy link

coderabbitai bot commented Feb 21, 2025

Walkthrough

The pull request updates the data/languages.json file by adding a variety of new language entries. These additions cover new projection items, ship decorations, cosmetic upgrades (including clan emblems, skins, scarves, sentinel tails, and sigils), and syndicate dog tags. The changes enhance the range of in-game items available through the language definitions without altering any control flow.

Changes

File Change Summary
data/languages.json Added new language entries for:
- Projections (e.g., /Lotus/.../Projections/T4VoidProjectionBaroAkmagnusPrimeBronze)
- Ship decorations
- Cosmetic upgrades including clan emblems, skins, scarves, sentinel tails, sigils
- Syndicate dog tag

Possibly related PRs

Suggested labels

released

Suggested reviewers

  • TobiTenno

Poem

I'm a bunny coding through the night,
Hopping through JSON with pure delight,
Adding projections and decos with flair,
Upgrades and sigils dance in the air,
My little paws tap the keys so light,
Celebrating changes in a rabbit's digital flight!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codeclimate bot commented Feb 21, 2025

Code Climate has analyzed commit 3790192 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
data/languages.json (1)

68-79: Review of Hunk 2: New Ship Decoration Entries
The additions for ship decorations ("/Lotus/StoreItems/Types/Items/ShipDecos/LisetPropCleaningDroneDuviri" and "/Lotus/StoreItems/Types/Items/ShipDecos/LisetPropCorpusBasilisk") have been inserted with the appropriate value strings. Verify that the spelling (e.g., “Domestik Dais Drone”) and naming conventions match the design specifications.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e63ea94 and 3790192.

📒 Files selected for processing (1)
  • data/languages.json (7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary
🔇 Additional comments (6)
data/languages.json (6)

29-37: Review of Hunk 1: New Projection Item Addition
The new JSON entry for the projection item ("/Lotus/StoreItems/Types/Game/Projections/T4VoidProjectionBaroAkmagnusPrimeBronze") is correctly formatted and consistent with the file’s overall structure. Ensure that the display name "Axi M5 Relic" complies with the intended in-game naming conventions.


95-112: Review of Hunk 3: Additional Ship Deco and Music Item
The new JSON entries for "/Lotus/StoreItems/Types/Items/ShipDecos/TarotCardTennoConJ" with value "Deimos Kymaeros Prex" and "/Lotus/StoreItems/Types/Items/SongItems/LotusEatersSongItem" with value "The Lotus Eaters Login Music" are correctly introduced. Their formatting is consistent and meets the expected schema.


134-142: Review of Hunk 4: Cosmetic Enhancer Update
The entry for "/Lotus/StoreItems/Upgrades/CosmeticEnhancers/Peculiars/EvilSpiritMod" with the value "Peculiar Audience" has been added correctly. The overall structure remains consistent.


194-217: Review of Hunk 5: New Clan and Infestation Skin Items
The new entries for clan emblems (keys such as CNY2022EmblemItem, CNY2023EmblemItem, CNY2025SnakeEmblem, and Dragon2024BadgeItem) as well as the infestation skin ("/Lotus/StoreItems/Upgrades/Skins/Infestation/NidusAlternateSkin") are well formatted and follow the established naming pattern. Confirm that each value (for example, "Lunar Renewal Tiger Emblem") exactly matches the expected in-game text.


239-265: Review of Hunk 6: Additional Cosmetic Upgrades for Scarves, Sentinels, and Sigils
The newly introduced entries for scarves ("/Lotus/StoreItems/Upgrades/Skins/Scarves/NezhaLeverianCape"), sentinel tails ("/Lotus/StoreItems/Upgrades/Skins/Sentinels/Tails/GaussSentinelTail"), and sigils (including "/Lotus/StoreItems/Upgrades/Skins/Sigils/1999DrippySigil", "/Lotus/StoreItems/Upgrades/Skins/Sigils/WeGameNewYearFreeTigerSigil", and "/Lotus/StoreItems/Upgrades/Skins/Sigils/WeGameNewYearOxSigil") are consistent with the file’s formatting standard. Please double-check that the descriptive text (e.g., "Lunar Renewal Tiger Sigil") exactly conveys the intended meaning.


329-337: Review of Hunk 7: New Syndicate Dog Tag Entry
The addition of the syndicate dog tag item ("/Lotus/Types/Items/SyndicateDogTags/UniversalSyndicateDogTag") with the value "Universal Medallion" looks correct and is consistent with the other entries. Confirm that this string entry is aligned with the design objectives stated in the PR.

@SlayerOrnstein SlayerOrnstein merged commit 9e00232 into WFCD:master Feb 22, 2025
9 checks passed
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants