New Crowdin updates #610
New Crowdin updates #610
Conversation
WalkthroughThis update adds multiple new entries to game language files across various locales. New booster packs, gameplay items, challenges, and upgrades have been integrated into various JSON files. Key additions include the "CalendarRivenPack" booster pack and "ArchonCrystalAmar" gameplay item, along with several new challenges under the "Calendar1999" category (such as those requiring enemies to be killed with abilities or melee) and upgrade options like "AbilityStrength," "GasChanceToPrimaryAndSecondary," "HealingEffects," "MeleeCritChance," and "RefundBulletOnStatusProc." Some locales also received additional package entries. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Code Climate has analyzed commit 2c5416e and detected 0 issues on this pull request. View more on Code Climate. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
data/de/languages.json (1)
410-413: New "AbilityStrength" Upgrade Added
The upgrade/Lotus/Upgrades/Calendar/AbilityStrengthwith the value"Power Gains"and description"Increase Ability Strength +25%.\n+25% Ability Strength"has been added. Consider reviewing the description to see if the duplicated information (pre- and post-newline) is intentional or if it could be consolidated.data/pl/languages.json (1)
410-413: New Upgrade: Ability Strength
The upgrade entry/Lotus/Upgrades/Calendar/AbilityStrengthwith value"Power Gains"and description"Increase Ability Strength +25%.\n+25% Ability Strength"is added. The duplicate percentage information (once before and after the newline) may be intentional for clarity, but consider simplifying it for better readability if possible.
data/tr/languages.json (1)
410-413: New Upgrade: AbilityStrength
The new upgrade entry"/Lotus/Upgrades/Calendar/AbilityStrength"is added with the value"Power Gains"and a description that indicates a +25% increase in ability strength. The description contains a redundant phrase; consider streamlining it for clarity (e.g., use a single, concise sentence).data/es/languages.json (1)
407-414: Upgrade Entry for Ability Strength:
The upgrade entry
"/Lotus/Upgrades/Calendar/AbilityStrength": { "value": "Power Gains", "desc": "Increase Ability Strength +25%.\n+25% Ability Strength" }
is introduced. Notably, the description repeats the bonus information. Consider consolidating or simplifying the description to avoid redundancy, unless the repeated phrasing is intended for tooltip and display differentiation.data/it/languages.json (1)
410-413: New Upgrade Entry: AbilityStrength
A new upgrade key "/Lotus/Upgrades/Calendar/AbilityStrength" with value "Power Gains" and a description that includes a newline ("Increase Ability Strength +25%.\n+25% Ability Strength") has been added. The description appears somewhat redundant; consider streamlining it for clarity if appropriate.data/ru/languages.json (1)
294-303: New Challenge Entry: CalendarKillEnemiesWithAbilitiesHard
A new challenge entry is added with the key/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHardand includes the value"Demonstration of power"and description"Kill 500 Enemies with Abilities". Please verify if using the same"Demonstration of power"label for both Hard and Medium challenges is intentional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
data/cs/languages.json(8 hunks)data/de/languages.json(8 hunks)data/es/languages.json(8 hunks)data/fr/languages.json(8 hunks)data/it/languages.json(8 hunks)data/ko/languages.json(8 hunks)data/pl/languages.json(8 hunks)data/pt/languages.json(8 hunks)data/ru/languages.json(8 hunks)data/sr/languages.json(8 hunks)data/tr/languages.json(8 hunks)data/uk/languages.json(8 hunks)data/zh/languages.json(8 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (118)
data/de/languages.json (13)
29-31: New "CalendarRivenPack" Entry Added
The new entry for/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPackwith the value"Riven"is added correctly. Please confirm that the term"Riven"suits the German locale or if further localization is required.
44-46: New "ArchonCrystalAmar" Entry Added
The entry/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmarwith the value"Crimson Archon Shard"is introduced. Verify that this string is consistent with the intended localized terminology, especially in comparison to other language files.
297-300: New "CalendarKillEnemiesWithAbilitiesHard" Challenge Added
The challenge is added with the title"Demonstration of power"and description"Kill 500 Enemies with Abilities". Please verify that using the same display text as the medium challenge is intentional and that the increased target (500 vs. 300) properly reflects the harder difficulty level.
309-312: New "CalendarKillEximusHard" Challenge Added
The new challenge entry now requires killing 30 Eximus, an increase from the easier variant. Ensure that this difficulty progression and the label"EX-EXIMUS"are as per the design specifications.
317-320: New "CalendarKillScaldraEnemiesMedium" Challenge Added
A new challenge targeting 350 Scaldra Troops has been added with the title"Punish Scaldra". Confirm that the incremental change from the easy variant (250 Troops) maintains the intended difficulty progression.
321-324: New "CalendarKillScaldraEnemiesWithAbilitiesEasy" Challenge Added
This entry, titled"Shock and Awe", sets an objective to kill 75 Scaldra Troops with abilities. Please verify that the “Easy” difficulty aligns with the reduced target and the overall balance for ability-based challenges.
329-332: New "CalendarKillTechrotEnemiesEasy" Challenge Added
The challenge"Purge the infection"now requires killing 250 Techrot enemies. Verify that labeling this challenge as easy fits with the game’s challenge scaling.
337-340: New "CalendarKillTechrotEnemiesWithMeleeMedium" Challenge Added
The new challenge"Electronic waste Disposal"specifies a goal of killing 200 Techrot enemies with melee weapons. Please ensure that this added mechanic is consistent with similar challenges and meets balance expectations.
371-373: New "CalendarKuvaBundleLarge" Package Entry Added
The package entry/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLargeis introduced with the value"6000 x Kuva". Confirm that the quantity and phrasing align with existing bundle entries and the overall game economy.
438-441: New "GasChanceToPrimaryAndSecondary" Upgrade Added
The upgrade specified at/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondaryis added with the value"Toxic Shot"and a description that offers a 25% Gas Status Chance for Primary and Secondary weapons. Please verify that the bonus aligns with gameplay balance requirements.
442-445: New "HealingEffects" Upgrade Added
The new upgrade/Lotus/Upgrades/Calendar/HealingEffectsprovides"Emergency Medicine"with a bonus of increasing Orb pickup restoration effects by 25%. Ensure that this effect is consistent with similar healing or restoration upgrades across locales.
454-457: New "MeleeCritChance" Upgrade Added
The upgrade/Lotus/Upgrades/Calendar/MeleeCritChanceis added with the value"Practiced Precision"and the description"+20% Melee Critical Chance (x2 for Heavy Attacks)". Confirm that this enhancement is balanced relative to other melee upgrades.
462-465: New "RefundBulletOnStatusProc" Upgrade Added
The upgrade at/Lotus/Upgrades/Calendar/RefundBulletOnStatusProcnow offers"Free Shot", granting a 10% chance to reload the triggering bullet upon a status proc. Please ensure that both the mechanic and the probability have been reviewed for proper game balance.data/cs/languages.json (10)
29-31: New Booster Pack Entry Added
The addition of the CalendarRivenPack entry with the value "Riven" is clear and concise. Please ensure that this terminology aligns with the official in-game naming conventions and is consistent across all locale files.
44-46: New Gameplay Item Entry Added
The new ArchonCrystalAmar entry, with the value "Crimson Archon Shard", is well-integrated. Verify that this terminology is consistent with the game lore and that corresponding translations in other language files mirror this update.
297-300: Challenge Entry with Duplicate Title
The newly added challenge CalendarKillEnemiesWithAbilitiesHard uses the title "Demonstration of power", which is identical to the medium variant. Please confirm whether this duplication is intentional or if a more distinctive title would improve clarity for players.
309-324: New Challenge Entries for Eximus and Scaldra
The additions of CalendarKillEximusHard, CalendarKillScaldraEnemiesMedium, and CalendarKillScaldraEnemiesWithAbilitiesEasy are implemented clearly. Ensure that the descriptions accurately reflect the intended difficulty levels and that the naming conventions remain consistent with existing challenges.
329-340: New Techrot Challenge Entries Added
The new entries for CalendarKillTechrotEnemiesEasy and CalendarKillTechrotEnemiesWithMeleeMedium are formatted correctly. Please verify that the phrasing ("Purge the infection" and "Electronic waste Disposal") meets design guidelines and clearly communicates the challenge objectives.
371-373: New Package Entry for Kuva Bundle
The CalendarKuvaBundleLarge entry with the value "6000 x Kuva" has been added. Confirm that the format of this value is consistent with other package entries and accurately represents the in-game quantity.
410-413: New Upgrade Entry for AbilityStrength
The addition of the AbilityStrength upgrade ("Power Gains") with a two-line description is clear. Please verify that the newline formatting is rendered as expected in the game UI and that the percentage increase is consistent with design specifications.
438-445: New Upgrade Entries for Gas and Healing Effects
The upgrades for GasChanceToPrimaryAndSecondary ("Toxic Shot") and HealingEffects ("Emergency Medicine") are well-defined with straightforward descriptions. Double-check that the percentage values and the phrasing match the overall upgrade mechanics and design documentation.
454-457: New Upgrade Entry for Melee Crit Chance
The MeleeCritChance entry ("Practiced Precision") with its accompanying description is clear. Ensure that the described boost (+20% Melee Critical Chance, with special handling for Heavy Attacks) is correctly applied within the game mechanics.
462-465: New Upgrade Entry for Refund Bullet on Status Proc
The RefundBulletOnStatusProc entry ("Free Shot") has been added with a clear description. Please confirm that the stated 10% chance to reload the bullet is balanced and accurately reflects the intended game mechanics.data/ko/languages.json (8)
29-31: New Booster Pack Entry: CalendarRivenPack Added
The new entry for the booster pack keyed by"/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPack"with the value"Riven"is added correctly. Please verify that the concise naming ("Riven") is consistent with similar entries across other locales.
44-46: New Gameplay Item: ArchonCrystalAmar Added
The addition of the gameplay item under"/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar"with the value"Crimson Archon Shard"appears correct. Confirm that the translation and context are in line with the game’s terminology and the corresponding entries in other language files.
297-300: New Challenge Entry: CalendarKillEnemiesWithAbilitiesHard Introduced
A new challenge entry is added with the key"/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard", using the value"Demonstration of power"and description"Kill 500 Enemies with Abilities". Note that the same value is used for the medium variant as well—please verify that this repetition is intentional and that the distinction between difficulties relies solely on the descriptive text.
309-312: Multiple New Challenge Updates for Calendar1999
This hunk introduces several new challenge entries:
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard"with value"EX-EXIMUS"and description"Kill 30 Eximus".- Updated Scaldra challenges, including an entry for medium difficulty (
"/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesMedium") and one using abilities ("/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesEasy").- Techrot challenge entries for both easy (
"/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesEasy") and melee-based challenges ("/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithMeleeMedium").Ensure that all descriptions accurately reflect the intended difficulty levels and that the in-game terminology remains consistent across locales.
Also applies to: 317-324, 329-332, 337-340
371-373: New Package Entry: CalendarKuvaBundleLarge Added
A new package entry for"/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge"with the value"6000 x Kuva"is included. Verify that this entry aligns with naming conventions and that its value meets the expected format compared to other Kuva bundle entries.
410-413: New Upgrade Entry: AbilityStrength Introduced
The upgrade entry for"/Lotus/Upgrades/Calendar/AbilityStrength"is added with the value"Power Gains"and a description containing a line break:
"Increase Ability Strength +25%.\n+25% Ability Strength".
The formatting is valid in JSON; just confirm consistency with similar upgrade entries across other locales.
438-445: New Upgrade Entries: GasChanceToPrimaryAndSecondary and HealingEffects
The hunk adds the upgrades"/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary"and"/Lotus/Upgrades/Calendar/HealingEffects"with clear values and descriptions. Double-check that the percentage values and wording are consistent with the overall game terminology and other language files.
454-457: New Upgrade Entries: MeleeCritChance and RefundBulletOnStatusProc Added
Two new upgrade entries have been added:
"/Lotus/Upgrades/Calendar/MeleeCritChance"with the value"Practiced Precision"and description"+20% Melee Critical Chance (x2 for Heavy Attacks).", and"/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc"with the value"Free Shot"and description"Triggering a status proc has a 10% chance to reload the triggering bullet into the clip."Ensure that these upgrade descriptions precisely reflect the intended game mechanics and follow the established style for similar entries.
Also applies to: 462-465
data/fr/languages.json (8)
29-31: New Booster Pack Entry Added
The entry for/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPackwith the value"Riven"has been correctly integrated. Please verify that this value is consistent with naming conventions used in other language files.
44-46: New Gameplay Item Entry Added
The new entry for/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmarfeaturing the value"Crimson Archon Shard"is clear and aligns with the intended update across locales.
297-300: New Challenge: Kill Enemies With Abilities (Hard)
The new challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHardwith the value"Demonstration of power"and description"Kill 500 Enemies with Abilities"is added as expected. Note that the same display text is used for both Hard and Medium difficulty challenges—please verify with the design team that this is intentional and won’t cause player confusion.
309-340: Multiple Challenge Entries Added
This hunk introduces several new challenge entries:
/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard(value:"EX-EXIMUS", desc:"Kill 30 Eximus")/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesMedium(value:"Punish Scaldra", desc:"Kill 350 Scaldra Troops")/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesEasy(value:"Shock and Awe", desc:"Kill 75 Scaldra Troops with Abilities")/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesEasy(value:"Purge the infection", desc:"Kill 250 Techrot")/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithMeleeMedium(value:"Electronic waste Disposal", desc:"Kill 200 Techrot with Melee Weapons")A couple of points to note:
- The challenge entries for Scaldra enemies use the same title
"Punish Scaldra"for different difficulty levels (Easy and Medium). Please confirm that this repetition is intentional or if differentiated naming should be considered for clarity.- Overall, ensure that these descriptions align with gameplay balance and translation consistency across all locales.
371-373: New Store Package Entry Added
The new package/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLargewith the value"6000 x Kuva"has been added. This entry appears consistent with similar entries in other language files.
410-413: New Upgrade Entry: AbilityStrength
The entry for/Lotus/Upgrades/Calendar/AbilityStrengthis introduced with the value"Power Gains"and a multi-line description. Ensure that the newline in the description is rendered correctly in the UI.
438-445: New Upgrade Entries: GasChanceToPrimaryAndSecondary & HealingEffects
The upgrades/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary(value"Toxic Shot") and/Lotus/Upgrades/Calendar/HealingEffects(value"Emergency Medicine") have been added. Their descriptions are clear; please verify that these terms are consistent with the overall upgrade scheme in the game localization.
454-465: New Upgrade Entries: MeleeCritChance & RefundBulletOnStatusProc
The additions of/Lotus/Upgrades/Calendar/MeleeCritChance(value"Practiced Precision") and/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc(value"Free Shot") are well defined. Ensure that the messaging here aligns with UI terminology and that the percentage details (e.g.,+20% Melee Critical Chanceand10% chance to reload...) are properly interpreted by the game interface.data/pt/languages.json (8)
26-34: New Booster Pack Entry for CalendarRivenPackThe new entry for
"/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPack"with the value"Riven"is added cleanly and follows the same formatting as the surrounding entries. Ensure that this addition aligns with the intended localization for booster packs.
41-49: New Gameplay Item Entry for ArchonCrystalAmarThe entry for
"/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar"is introduced with the value"Crimson Archon Shard". The JSON structure and formatting are consistent with existing entries in this section.
294-303: New Challenge Entry for CalendarKillEnemiesWithAbilitiesHardThe new challenge
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard"is added with the value"Demonstration of power"and the description"Kill 500 Enemies with Abilities". This entry is clear and follows the established pattern for challenge definitions. Please verify that the challenge naming and difficulty (Hard) match the game design specifications.
306-341: Multiple New Challenge Entries for Calendar1999This hunk introduces several new challenge entries:
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard"with the value"EX-EXIMUS"and description"Kill 30 Eximus"."/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesMedium"with the value"Punish Scaldra"and description"Kill 350 Scaldra Troops"."/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesEasy"with the value"Shock and Awe"and description"Kill 75 Scaldra Troops with Abilities"."/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesEasy"with the value"Purge the infection"and description"Kill 250 Techrot"."/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithMeleeMedium"with the value"Electronic waste Disposal"and description"Kill 200 Techrot with Melee Weapons".All of these new entries are formatted correctly and appear to integrate well with the existing challenge structure. It’s advisable to double-check that the challenge titles and descriptions fully match the intended game mechanics.
368-376: New Package Entry for CalendarKuvaBundleLargeThe entry
"/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge"with the value"6000 x Kuva"is added correctly. Its structure is consistent with the similar small bundle entry. Confirm that this large package is referenced as expected in the game.
407-416: New Upgrade Entry for AbilityStrengthThe new upgrade
"/Lotus/Upgrades/Calendar/AbilityStrength"is introduced with the value"Power Gains"and a multi-line description"Increase Ability Strength +25%.\n+25% Ability Strength". This is well-formatted; just verify that the newline character in the description renders as intended in the game UI.
435-448: New Upgrade Entries for GasChanceToPrimaryAndSecondary and HealingEffectsThis hunk adds the following upgrade entries:
"/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary"with the value"Toxic Shot"and description"Add 25% Gas Status Chance to Primary and Secondary weapons.""/Lotus/Upgrades/Calendar/HealingEffects"with the value"Emergency Medicine"and description"All restoration effects provided by Orb pickups increased by 25%."Both entries follow the established structure and naming conventions. They integrate smoothly with the rest of the upgrade entries.
451-468: New Upgrade Entries for MeleeCritChance and RefundBulletOnStatusProcThe additions include:
"/Lotus/Upgrades/Calendar/MeleeCritChance"with the value"Practiced Precision"and description"+20% Melee Critical Chance (x2 for Heavy Attacks).""/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc"with the value"Free Shot"and description"Triggering a status proc has a 10% chance to reload the triggering bullet into the clip."These new entries are clear and maintain consistency with other upgrade definitions. Ensure that their concise descriptions match the designed in-game effects.
data/pl/languages.json (13)
29-31: New Booster Pack Entry Added
The new entry for/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPackwith the value"Riven"has been correctly added. Ensure that the terminology aligns with other similar entries in the locale.
44-46: New Gameplay Item Entry Added
The new entry for/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmarwith the value"Crimson Archon Shard"is added as expected. Verify consistency with similar keys across locales.
297-300: New Challenge: High-Difficulty Ability Kill
The challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHardwith value"Demonstration of power"and description"Kill 500 Enemies with Abilities"has been introduced. Confirm that this difficulty tier and phrasing align with game design standards.
309-312: New Challenge: Hard Eximus Kill
A new challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHardhas been added with value"EX-EXIMUS"and description"Kill 30 Eximus". This provides a tougher variant than the existing easy challenge.
317-320: New Challenge: Medium Scaldra Kill
The addition of/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesMediumwith the requirement to"Kill 350 Scaldra Troops"is clear and aligns with the progression of challenges.
321-324: New Ability-Based Challenge for Scaldra
The entry/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesEasyis added with the description"Kill 75 Scaldra Troops with Abilities". Confirm that the difficulty level (“Easy”) is appropriate given the numerical target.
329-332: New Challenge: Easy Techrot Kill
The challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesEasywith"Kill 250 Techrot"has been introduced. Please ensure that its difficulty label (“Easy”) and numerical target are consistent with design expectations.
337-340: New Challenge: Melee-Based Techrot Kill
The addition of/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithMeleeMediumwith the target"Kill 200 Techrot with Melee Weapons"is clear. Verify that this challenge meshes well with other melee-based challenges in terms of difficulty.
371-373: New Store Package Entry Added
The new package entry/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLargewith the value"6000 x Kuva"is included. Confirm that the naming conventions and quantity representations match other similar entries.
438-441: New Upgrade: Gas Status Chance
The new upgrade/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondarywith value"Toxic Shot"and description"Add 25% Gas Status Chance to Primary and Secondary weapons."has been added. This aligns well with the upgrade theme.
442-445: New Upgrade: Healing Effects
The entry/Lotus/Upgrades/Calendar/HealingEffectswith value"Emergency Medicine"and description"All restoration effects provided by Orb pickups increased by 25%."is added. Please verify consistency with other healing-related upgrades.
454-457: New Upgrade: Melee Critical Chance
The upgrade entry/Lotus/Upgrades/Calendar/MeleeCritChancewith value"Practiced Precision"and description"+20% Melee Critical Chance (x2 for Heavy Attacks)."is added. The value and description appear correctly formatted.
462-465: New Upgrade: Refund Bullet on Status Proc
The new entry/Lotus/Upgrades/Calendar/RefundBulletOnStatusProcwith value"Free Shot"and description"Triggering a status proc has a 10% chance to reload the triggering bullet into the clip."is added. Confirm that the description is clear and consistent with upgrade documentation.data/tr/languages.json (12)
29-31: New Booster Pack Entry Added
The entry for"/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPack"with the value"Riven"is added correctly. Please verify that this naming and value are consistent with similar entries across other locale files.
44-46: New Gameplay Item Addition
The newly added entry"/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar"with the value"Crimson Archon Shard"matches the expected update for new gameplay items.
297-300: New Challenge - Abilities Hard
The challenge"/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard"is introduced with a requirement to kill 500 enemies using abilities. The value"Demonstration of power"and description are consistent with an increased difficulty level compared to the medium variant.
309-312: New Challenge: Eximus Hard
The challenge"/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard"is added with the value"EX-EXIMUS"and description"Kill 30 Eximus". This provides a clear escalation over the easier variant.
317-320: New Challenge: Scaldra Enemies Medium
The new entry"/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesMedium"with value"Punish Scaldra"and description"Kill 350 Scaldra Troops"is added. Please ensure that the numeric target scales appropriately with the game's challenge progression.
321-324: New Challenge: Scaldra with Abilities Easy
The added challenge"/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesEasy"(value"Shock and Awe", description"Kill 75 Scaldra Troops with Abilities") is a nice addition. Verify that its difficulty distinctly differentiates it from similar Scaldra challenge variants.
329-332: New Challenge: Techrot Enemies Easy
The challenge"/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesEasy"with value"Purge the infection"and description"Kill 250 Techrot"is added correctly. Confirm that the target numbers are balanced with other similar challenges.
337-340: New Challenge: Techrot Enemies with Melee Medium
The entry"/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithMeleeMedium"is introduced with the value"Electronic waste Disposal"and description"Kill 200 Techrot with Melee Weapons". Please review the numeric requirements to ensure the intended balance is maintained.
371-373: New Store Package for Large Kuva Bundle
The addition of"/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge"with the value"6000 x Kuva"is clear and consistent with the tiered packaging. Ensure that this value is in line with regional standards and other locale entries.
438-445: New Upgrades: Gas Chance & Healing Effects
The upgrades"/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary"(value"Toxic Shot") and"/Lotus/Upgrades/Calendar/HealingEffects"(value"Emergency Medicine") are added with clear descriptions. These entries enhance the upgrade system; please double-check that the descriptions are consistent across all locale files.
454-457: New Upgrade: Melee Critical Chance
The addition of"/Lotus/Upgrades/Calendar/MeleeCritChance"with the value"Practiced Precision"and its corresponding description is clear and descriptive.
462-465: New Upgrade: Refund Bullet on Status Proc
The new entry"/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc"with the value"Free Shot"is introduced along with its description. This entry is well-defined and aligns with the intended game mechanic.data/zh/languages.json (8)
26-34: New Store Item Entry Added
A new entry for the booster pack “CalendarRivenPack” with the value “Riven” has been added. Please ensure that its naming and data structure are consistent with existing entries and across other locales.
41-49: New Gameplay Item: ArchonCrystalAmar Added
The entry for “/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar” with the value “Crimson Archon Shard” is introduced. Verify that this addition matches the design specifications and is in line with similar entries in other language files.
294-303: Challenge Addition: Kill Enemies With Abilities (Hard)
The new challenge “/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard” is added with the value “Demonstration of power” and the description “Kill 500 Enemies with Abilities.” Please ensure that the difficulty level and wording are consistent with similar challenges (e.g., the medium variant) and adhere to game terminology.
306-343: Multiple Challenge Entries for Eximus, Scaldra, and Techrot
Several new challenges have been introduced:
- The hard Eximus challenge “/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard” has a Chinese description ("击杀30名卓越者") while its counterpart in the easy version is in English.
- Additional Scaldra challenges for different difficulties and a Techrot challenge are also added.
Please confirm that the mix of languages is intentional and that the difficulty settings and descriptions align properly with design guidelines.
368-376: New Package Entry: CalendarKuvaBundleLarge
The package entry “/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge” with the value “6000 x Kuva” is added. Verify consistency with other package entries and ensure this update reflects the intended in-game reward scaling.
407-416: New Upgrade Entry: AbilityStrength Added
An upgrade entry for “/Lotus/Upgrades/Calendar/AbilityStrength” with the value “Power Gains” and a multiline description is now present. Please confirm that the newline in the description is correctly interpreted by the game and that the upgrade’s effects are properly documented.
435-448: New Upgrade Entries: Toxic Shot and Emergency Medicine Introduced
The updates add:
- “/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary” with the value “Toxic Shot.”
- “/Lotus/Upgrades/Calendar/HealingEffects” with the value “Emergency Medicine.”
Ensure that the percentages and description texts (e.g., “Add 25% Gas Status Chance…” and “All restoration effects provided by Orb pickups increased by 25%”) are accurate and consistent with game mechanics and similar locale files.
451-468: New Upgrade Entries: Practiced Precision and Free Shot Added
The new additions include:
- “/Lotus/Upgrades/Calendar/MeleeCritChance” with the value “Practiced Precision.”
- “/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc” with the value “Free Shot.”
Please verify that the percentage descriptors (e.g., “+20% Melee Critical Chance (x2 for Heavy Attacks)” and “Triggering a status proc has a 10% chance to reload the triggering bullet into the clip”) accurately reflect the in-game upgrade effects and are consistently formatted with other upgrade entries.data/es/languages.json (7)
26-31: Booster Pack Entry Consistency Check:
The new booster pack entry for
"/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPack": { "value": "Riven" }
has been added correctly. Please verify that its key placement and naming conventions follow the same order and style as other booster pack entries in this file to maintain consistency.
44-46: Gameplay Item Addition Verification:
The new gameplay item entry for
"/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar": { "value": "Crimson Archon Shard" }
has been added. Ensure that the localized text ("Crimson Archon Shard") is accurate and consistent with similar entries across other locale files.
297-300: Challenge Entry Addition:
The new challenge
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard": { "value": "Demonstration of power", "desc": "Kill 500 Enemies with Abilities" }
is introduced. This entry appears coherent with the challenge naming and description style. Please confirm that the numerical target (500 enemies) and the descriptive text fulfill the intended design criteria.
309-340: Enhanced Challenge Entries Review:
Several new and updated challenge entries have been introduced:
- Eximus Challenges: The new key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard": { "value": "EX-EXIMUS", "desc": "Kill 30 Eximus" }
contrasts with an existing entry for killing 10 Eximus. Please verify that these differences correctly represent varying difficulty levels.- Scaldra and Techrot Challenges: New entries with updated kill counts (e.g., "Kill 350 Scaldra Troops", "Kill 250 Techrot", and "Kill 200 Techrot with Melee Weapons") have been added. Ensure that the numbers and descriptive texts align with game design and are consistent with updates in other locales.
368-376: Store Package Addition Check:
The new package entry
"/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge": { "value": "6000 x Kuva" }
has been added. Confirm that the packaging details ("6000 x Kuva") are formatted in line with similar offers in other locale files and that the key placement is appropriate.
435-448: New Upgrades – Gas and Healing Effects:
The entries for:
"/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary": { "value": "Toxic Shot", "desc": "Add 25% Gas Status Chance to Primary and Secondary weapons." }"/Lotus/Upgrades/Calendar/HealingEffects": { "value": "Emergency Medicine", "desc": "All restoration effects provided by Orb pickups increased by 25%." }
have been added. Please ensure that the numeric and textual details are consistent with the format used in similar upgrade entries across other languages.
451-468: Additional Upgrade Additions Check:
The new upgrade entries:
"/Lotus/Upgrades/Calendar/MeleeCritChance": { "value": "Practiced Precision", "desc": "+20% Melee Critical Chance (x2 for Heavy Attacks)." }"/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc": { "value": "Free Shot", "desc": "Triggering a status proc has a 10% chance to reload the triggering bullet into the clip." }
have been added. Their descriptive texts and numeric modifiers appear clear. Please verify that these entries meet the design specifications and follow the established description style as seen in previous entries.data/sr/languages.json (8)
26-34: New Booster Pack Entry: CalendarRivenPack
A new entry has been added for the "CalendarRivenPack" with a value of "Riven". This entry is consistent with similar booster pack additions in other locales. Please verify that it aligns with overall naming conventions and that any related changes in other language files are synchronized.
41-49: New Gameplay Item: ArchonCrystalAmar
The new gameplay item "ArchonCrystalAmar" has been introduced with the value "Crimson Archon Shard". Ensure that this entry maintains consistency in style and key naming with other language files.
294-303: New Challenge Addition: CalendarKillEnemiesWithAbilitiesHard
A new challenge under the Calendar1999 category has been added with the key/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard(value: "Demonstration of power", description: "Kill 500 Enemies with Abilities"). Confirm that the challenge difficulty and description align with the intended game mechanics and that similar challenges in other locales reflect a consistent upgrade.
306-341: Multiple Challenge Enhancements in Calendar1999 Category
Several new challenge entries have been introduced or adjusted:
/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHardnow requires killing 30 Eximus.- Additional challenges for Scaldra and Techrot enemies have been added, such as medium difficulty for Scaldra and melee-specific requirements for Techrot enemies.
Please verify that:
- All new keys follow the established naming conventions.
- The descriptions are clear and aligned with player expectations.
- Numeric values (e.g., enemy counts) are balanced with existing challenges.
368-376: New Store Item Entry: CalendarKuvaBundleLarge
A new store item for/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLargewith the value "6000 x Kuva" has been added. This addition extends the store offerings and should be cross-checked with similar entries (e.g., CalendarKuvaBundleSmall) to ensure consistent formatting and pricing strategy.
407-416: New Upgrade Entry: AbilityStrength
A new upgrade entry for/Lotus/Upgrades/Calendar/AbilityStrengthis introduced with the value "Power Gains" and a description that includes a newline for clarity. Please ensure the newline formatting is rendered correctly in the game’s UI and that this upgrade is aligned with the overall upgrade structure.
435-448: Additional Upgrade Entries: GasChanceToPrimaryAndSecondary & HealingEffects
Two new upgrades are added:
/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary("Toxic Shot", description: "Add 25% Gas Status Chance to Primary and Secondary weapons.")/Lotus/Upgrades/Calendar/HealingEffects("Emergency Medicine", description: "All restoration effects provided by Orb pickups increased by 25%.")These entries appear well-formed and consistent with other upgrade keys. Confirm that the percentages and descriptions match game design standards across locales.
451-468: New Upgrade Entries: MeleeCritChance & RefundBulletOnStatusProc
This hunk introduces two new upgrades:
/Lotus/Upgrades/Calendar/MeleeCritChancewith the value "Practiced Precision" and a description indicating a +20% increase in melee critical chance (doubling for heavy attacks)./Lotus/Upgrades/Calendar/RefundBulletOnStatusProcwith the value "Free Shot" and a description that provides a 10% chance to reload a bullet on triggering a status proc.Both entries are clear and adhere to the established JSON structure. Ensure that these updates are documented properly with corresponding assets in the game.
data/it/languages.json (7)
29-31: New Booster Pack Entry Added
A new entry for the booster pack "/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPack" with the value "Riven" has been introduced. This addition follows the expected pattern seen in other locale files.
44-46: New Gameplay Item Entry Introduced
The new key "/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmar" with the value "Crimson Archon Shard" has been added. This aligns well with the additions across other locale files.
297-300: New Challenge for Abilities - Hard Level
The challenge "/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHard" is added with the display value "Demonstration of power" and description "Kill 500 Enemies with Abilities". Note that the same display text is used for the medium challenge as well. Please verify if the duplication is intentional or if differentiation is needed for clarity.
309-340: Multiple New Challenge Entries Under Calendar1999
This hunk adds several new challenge entries including:
- Eximus Challenge (Hard): "/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard" with value "EX-EXIMUS" and desc "Kill 30 Eximus".
- Scaldra Challenges: Easy ("/CalendarKillScaldraEnemiesEasy") and Medium ("/CalendarKillScaldraEnemiesMedium") with respective target counts, plus a variant with abilities ("/CalendarKillScaldraEnemiesWithAbilitiesEasy").
- Techrot Challenges: Easy ("/CalendarKillTechrotEnemiesEasy") and a melee variant ("/CalendarKillTechrotEnemiesWithMeleeMedium").
Ensure that the naming conventions, difficulty scaling, and display text consistency across these challenges match the design intent and remain consistent with other locale files.
371-373: New Store Item Package Added
The new package entry "/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLarge" with the value "6000 x Kuva" has been introduced. This addition is consistent with similar entries in other language files.
435-448: New Upgrade Entries: GasChanceToPrimaryAndSecondary & HealingEffects
The upgrades "/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondary" (value "Toxic Shot") and "/Lotus/Upgrades/Calendar/HealingEffects" (value "Emergency Medicine") have been added with clear descriptions. These entries look consistent with the overall update.
454-465: New Upgrade Entries: MeleeCritChance & RefundBulletOnStatusProc
The keys "/Lotus/Upgrades/Calendar/MeleeCritChance" (value "Practiced Precision") and "/Lotus/Upgrades/Calendar/RefundBulletOnStatusProc" (value "Free Shot") are added with appropriate descriptions. These entries are clear and consistent with the new gameplay upgrade theme.data/ru/languages.json (7)
26-34: New Booster Pack Entry: CalendarRivenPack
The addition of the/Lotus/StoreItems/Types/BoosterPacks/CalendarRivenPackkey with the value"Riven"is consistent with similar entries in other locales.
41-49: New Gameplay Item: ArchonCrystalAmar
The entry for/Lotus/StoreItems/Types/Gameplay/NarmerSorties/ArchonCrystalAmarwith the value"Crimson Archon Shard"is implemented as expected and aligns with updates in other language files.
306-343: Additional Calendar1999 Challenge Updates
Multiple new challenge entries have been incorporated in this hunk:
/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHardnow provides a localized Russian description ("Убейте 30 эксимусов").- Various Scaldra and Techrot challenge entries (Easy, Medium, and with specific conditions) have been added with clear, descriptive texts.
Please ensure that the mixture of localized (e.g., Russian in
/Lotus/Types/Challenges/Calendar1999/CalendarKillEximusHard) and non-localized strings is intentional based on your localization strategy for the Russian language file.
368-376: New Store Package Entry: CalendarKuvaBundleLarge
The new entry for/Lotus/Types/StoreItems/Packages/Calendar/CalendarKuvaBundleLargewith the value"6000 x Kuva"fits well with the similar entries in other locales and appears correct.
407-416: New Upgrade Entry: AbilityStrength
The addition of/Lotus/Upgrades/Calendar/AbilityStrengthwith the value"Power Gains"and its description is in line with the update objectives. The formatting (including the newline) appears consistent with similar entries.
435-448: New Upgrade Entries: GasChanceToPrimaryAndSecondary and HealingEffects
This hunk introduces new upgrade entries:
/Lotus/Upgrades/Calendar/GasChanceToPrimaryAndSecondarywith value"Toxic Shot"./Lotus/Upgrades/Calendar/HealingEffectswith value"Emergency Medicine".Both are well-defined, and the associated descriptions clearly communicate the intended gameplay changes.
451-468: New Upgrade Entries: MeleeCritChance and RefundBulletOnStatusProc
The new entries for/Lotus/Upgrades/Calendar/MeleeCritChanceand/Lotus/Upgrades/Calendar/RefundBulletOnStatusProcare added correctly with their respective values and descriptions. They align with the overall update objectives and provide clear instructions for the upgrades.data/uk/languages.json (9)
29-31: New Booster Pack Entry: "CalendarRivenPack" AddedThe addition of the "CalendarRivenPack" entry with the value "Riven" is correctly formatted and aligns with similar entries in other language files.
44-46: New Gameplay Item Entry: "ArchonCrystalAmar"The entry introducing "ArchonCrystalAmar" with the value "Crimson Archon Shard" is implemented consistently with the design intentions. Verify that this matches the terminology used in other locales for uniformity.
297-300: New Challenge Entry: "CalendarKillEnemiesWithAbilitiesHard"This new challenge entry—with the value "Демонстрація сили" and description "Kill 500 Enemies with Abilities"—is added correctly. Confirm that its difficulty level is properly distinguished from the medium variant.
309-340: Multiple New Challenge Entries AddedThis hunk introduces several new challenge entries:
- CalendarKillEximusHard (lines 309–312) with an increased kill target.
- CalendarKillScaldraEnemiesMedium (lines 317–320) and CalendarKillScaldraEnemiesWithAbilitiesEasy (lines 321–324) with updated descriptions.
- CalendarKillTechrotEnemiesEasy (lines 329–332) and CalendarKillTechrotEnemiesWithMeleeMedium (lines 337–340) with their respective descriptions.
Please ensure that all challenge difficulty levels, names, and descriptions remain consistent with the game design and the translations used in other locale files.
371-373: New Package Entry: "CalendarKuvaBundleLarge"The new package entry with the value "6000 x Kuva" is added as expected. Verify that its formatting and value are consistent with similar package entries in other language files.
410-413: New Upgrade Entry: "AbilityStrength"The upgrade "AbilityStrength" with the value "Power Gains" and the description
"Increase Ability Strength +25%.\n+25% Ability Strength"is implemented correctly. The newline escape sequence is properly used for formatting.
438-445: New Upgrade Entries: "GasChanceToPrimaryAndSecondary" and "HealingEffects"The upgrades for "GasChanceToPrimaryAndSecondary" (value "Toxic Shot") and "HealingEffects" (value "Emergency Medicine") are added correctly with clear descriptions. Please double-check that these entries are consistent with the mechanics and translations used in other locale files.
454-457: New Upgrade Entry: "MeleeCritChance"The entry for "MeleeCritChance" with the value "Practiced Precision" and its description is added properly. Confirm that the percentage effect (20% and the note on Heavy Attacks) aligns with game balance expectations.
462-465: New Upgrade Entry: "RefundBulletOnStatusProc"The new upgrade "RefundBulletOnStatusProc" with the value "Free Shot" and the description detailing a 10% chance to reload the bullet is correctly added. Ensure that the effect and its documentation are consistent with other similar upgrades in the system.
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit